Skip to content

Chore: Downgrade logging for other addresses received in cngd#905

Merged
justinfrevert merged 3 commits into
mainfrom
chore/reduce-cngd-address-logging
Mar 11, 2026
Merged

Chore: Downgrade logging for other addresses received in cngd#905
justinfrevert merged 3 commits into
mainfrom
chore/reduce-cngd-address-logging

Conversation

@justinfrevert

@justinfrevert justinfrevert commented Mar 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@justinfrevert justinfrevert requested a review from a team as a code owner March 11, 2026 14:39
@justinfrevert justinfrevert changed the title reduce logging for other addresses received in cngd Chore: Reduce logging for other addresses received in cngd Mar 11, 2026
@github-actions

github-actions Bot commented Mar 11, 2026

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 44
LOW LOW 3
INFO INFO 59
TRACE TRACE 0
TOTAL TOTAL 106
Metric Values
Files scanned placeholder 26
Files parsed placeholder 26
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 11

@justinfrevert justinfrevert requested a review from ozgb March 11, 2026 14:42
gilescope
gilescope reviewed Mar 11, 2026
View reviewed changes
Comment thread primitives/mainchain-follower/src/data_source/cnight_observation.rs
@gilescope gilescope changed the title Chore: Reduce logging for other addresses received in cngd Chore: Downgrade logging for other addresses received in cngd Mar 11, 2026
ozgb
ozgb approved these changes Mar 11, 2026
View reviewed changes

@ozgb ozgb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The other logs in that file can stay as errors - those are genuine errors, if we can't decode the plutus data on a mapping_validator utxo, that's an error with the node

@justinfrevert justinfrevert added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 753f550 Mar 11, 2026
37 checks passed
@justinfrevert justinfrevert deleted the chore/reduce-cngd-address-logging branch March 11, 2026 18:43
gilescope pushed a commit that referenced this pull request Apr 8, 2026
@LGLO
Parsing registered candidates datum v1 (#905)
ff97047
@gilescope gilescope added this to the node-1.0.0 milestone Apr 10, 2026
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
Parsing registered candidates datum v1 (#905)
aa4f7f1 
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
Parsing registered candidates datum v1 (#905)
92439e5 
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gilescope gilescope gilescope left review comments

@ozgb ozgb ozgb approved these changes

Assignees

No one assigned

Labels

release:node-0.22.0 skip-changes-check-jira

Projects

None yet

Milestone

node-1.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@justinfrevert @gilescope @ozgb @TheNewAutonomy