fix: toolkit logging improvements#899
Merged
Merged
Conversation
…subscriber Replace structured-logger with tracing-subscriber for unified logging. This fixes --verbose not filtering correctly and adds --verbose-fetch and --verbose-ledger flags for fine-grained per-target log control. Uses EnvFilter with prefix matching (with_regex(false)) so that more specific target directives properly override broader ones. RUST_LOG still takes precedence over all CLI flags when set.
Contributor
gilescope
approved these changes
Mar 11, 2026
gilescope
left a comment
Contributor
There was a problem hiding this comment.
less deps is a faster build. approved.
ozgb
added a commit
that referenced
this pull request
Mar 11, 2026
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Overview
structured_loggerin favour oftracing_subscriber--verbose-fetchand--verbose-ledgerfor controlling outputRUST_LOGRUST_LOGenv-var now also sets ledger log verbosityVerbose logging can expose secrets, which is why it's not default. This follows convention set in other tools (e.g.
curl -v,ssh -v, etc.)🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links