Skip to content

fix: toolkit logging improvements#899

Merged
gilescope merged 5 commits into
mainfrom
ozgb-toolkit-logging-improvements-v2
Mar 11, 2026
Merged

fix: toolkit logging improvements#899
gilescope merged 5 commits into
mainfrom
ozgb-toolkit-logging-improvements-v2

Conversation

@ozgb

@ozgb ozgb commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

Overview

  • Remove structured_logger in favour of tracing_subscriber
    • Breaking: As a result, JSON format is slightly different
  • Add two new verbose flags, --verbose-fetch and --verbose-ledger for controlling output
    • Can be overriden via RUST_LOG
  • RUST_LOG env-var now also sets ledger log verbosity

Verbose logging can expose secrets, which is why it's not default. This follows convention set in other tools (e.g. curl -v, ssh -v, etc.)

🗹 TODO before merging

  • Ready
  • Add change files

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

ozgb added 2 commits March 10, 2026 16:16
…subscriber

Replace structured-logger with tracing-subscriber for unified logging.
This fixes --verbose not filtering correctly and adds --verbose-fetch
and --verbose-ledger flags for fine-grained per-target log control.
Uses EnvFilter with prefix matching (with_regex(false)) so that more
specific target directives properly override broader ones. RUST_LOG
still takes precedence over all CLI flags when set.
@ozgb ozgb requested a review from a team as a code owner March 10, 2026 17:20
@github-actions

github-actions Bot commented Mar 10, 2026

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 47
LOW LOW 3
INFO INFO 59
TRACE TRACE 0
TOTAL TOTAL 109
Metric Values
Files scanned placeholder 26
Files parsed placeholder 26
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 12

@gilescope gilescope left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

less deps is a faster build. approved.

@gilescope gilescope added this pull request to the merge queue Mar 11, 2026
Merged via the queue into main with commit 69d2ee9 Mar 11, 2026
34 of 35 checks passed
@gilescope gilescope deleted the ozgb-toolkit-logging-improvements-v2 branch March 11, 2026 07:07
ozgb added a commit that referenced this pull request Mar 11, 2026
@ozgb ozgb mentioned this pull request Mar 11, 2026
14 tasks
github-merge-queue Bot pushed a commit that referenced this pull request Mar 11, 2026
@gilescope gilescope added this to the node-1.0.0 milestone Apr 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants