feat: enable contract_custom builder for ledger 7#864
Merged
Conversation
Move version-specific types (EncodedOutputInfo, EncodedInputInfo, EncodedTransientInfo) and their trait impls from encoded_zswap_local_state.rs into the version-parameterized contract_custom.rs module. This allows them to use version-local types (BuildOutput, BuildInput, etc.) and work correctly for both ledger 7 and ledger 8. - Add conversion helpers that bridge between ledger_8 encoded types and version-local ledger types (CoinInfo, Recipient, etc.) - Widen field visibility to pub(crate) for cross-module access - Convert UtxoId and WalletAddress via string representation in the constructor to handle cross-version type differences
Contributor
|
KICS version: v2.1.19
|
Use version-local ContractEffects type instead of direct midnight_node_ledger_helpers imports to avoid duplicate definitions and version mismatches.
jsidorenko
reviewed
Mar 11, 2026
gilescope
approved these changes
Mar 11, 2026
gilescope
pushed a commit
that referenced
this pull request
Apr 8, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The contract_custom transaction builder now works on chains still at ledger 7, removing the previous "not supported for ledger 7" error.
Ticket: https://shielded.atlassian.net/browse/PM-22229
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links