)

* revert tagged serialization for contract addresses and coin public

* change file

* remove remaining tag arguments for coin publics and contract addresses

* comment out ephemeral env test in ci

* remove --tagged

---------

Co-authored-by: Squirrel <giles.cope@shielded.io>
Signed-off-by: Giles Cope <gilescope@gmail.com>

This reverts commit 2e3dba3.

This reverts commit 2e3dba3.
Signed-off-by: Mike Clay <mike.clay@shielded.io>

This reverts commit 2e3dba3.
Signed-off-by: Mike Clay <mike.clay@shielded.io>

Revert coin_public_decode and contract_address_decode to use
hex_ledger_untagged_decode. Per ADR-0022 wallet keys and addresses use
untagged serialization; Bech32m HRP plays the role of a tag at the
user-facing boundary. The same tagged-switch was attempted and reverted
in PR #853; inline comments above both parsers cite ADR-0022 and PR #853
to prevent future re-introduction.

EOF enforcement on hex_ledger_untagged_decode (the audit-#307 fix) and
the improved error-message wording ("invalid hex input") are retained.
The unit tests are rewritten to assert untagged-acceptance plus EOF /
truncation / invalid-hex rejection on coin_public_decode,
contract_address_decode, and hex_ledger_untagged_decode::<HashOutput>.
The tagged test fixture (contract_address_undeployed_tagged.mn) is
removed and generate_txs.rs reverts to the existing untagged fixture.

Closes #307

Signed-off-by: Mike Clay <mike.clay@shielded.io>

…t Issue H) (midnightntwrk#1437)

* fix(toolkit): switch CLI parsers to tagged deserialization

Switch coin_public_decode and contract_address_decode from
hex_ledger_untagged_decode to hex_ledger_decode (tagged), eliminating
the unconditional fallback that accepted untagged input for types that
implement Tagged.

- Replace hex_ledger_untagged_decode with hex_ledger_decode in
  coin_public_decode and contract_address_decode
- Add EOF enforcement to hex_ledger_untagged_decode (defense-in-depth)
- Update test fixture in generate_txs.rs to use tagged hex format
- Add 11 unit tests covering tagged/untagged/wrong-tag/trailing-bytes/
  invalid-hex scenarios

Closes #307

Signed-off-by: Mike Clay <mike.clay@shielded.io>

* fix(toolkit): keep CLI parsers untagged per ADR-0022; enforce EOF

Revert coin_public_decode and contract_address_decode to use
hex_ledger_untagged_decode. Per ADR-0022 wallet keys and addresses use
untagged serialization; Bech32m HRP plays the role of a tag at the
user-facing boundary. The same tagged-switch was attempted and reverted
in PR midnightntwrk#853; inline comments above both parsers cite ADR-0022 and PR midnightntwrk#853
to prevent future re-introduction.

EOF enforcement on hex_ledger_untagged_decode (the audit-#307 fix) and
the improved error-message wording ("invalid hex input") are retained.
The unit tests are rewritten to assert untagged-acceptance plus EOF /
truncation / invalid-hex rejection on coin_public_decode,
contract_address_decode, and hex_ledger_untagged_decode::<HashOutput>.
The tagged test fixture (contract_address_undeployed_tagged.mn) is
removed and generate_txs.rs reverts to the existing untagged fixture.

Closes #307

Signed-off-by: Mike Clay <mike.clay@shielded.io>

---------

Signed-off-by: Mike Clay <mike.clay@shielded.io>