Skip to content

Pass the latest ledger parameters on intent generation#837

Merged
jsidorenko merged 14 commits into
mainfrom
js/PM-22073-toolkit-pass-ledger-params
Mar 4, 2026
Merged

Pass the latest ledger parameters on intent generation#837
jsidorenko merged 14 commits into
mainfrom
js/PM-22073-toolkit-pass-ledger-params

Conversation

@jsidorenko

@jsidorenko jsidorenko commented Mar 2, 2026 •
edited by ozgb
Loading

Copy link
Copy Markdown
Contributor

Overview

Fetch the latest LedgerParameters from the chain and pass them as input to toolkit.js when generating intents.

🗹 TODO before merging

  • Update compact.js version

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Closes: https://shielded.atlassian.net/browse/PM-22073

@github-actions

github-actions Bot commented Mar 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.19

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 47
LOW LOW 3
INFO INFO 59
TRACE TRACE 0
TOTAL TOTAL 109
Metric Values
Files scanned placeholder 27
Files parsed placeholder 27
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 11

@jsidorenko jsidorenko requested a review from ozgb March 2, 2026 15:23
ozgb
ozgb reviewed Mar 2, 2026
View reviewed changes
Comment thread util/toolkit/src/commands/generate_intent.rs Outdated
ozgb
ozgb reviewed Mar 2, 2026
View reviewed changes
Comment thread util/toolkit/src/commands/generate_intent.rs Outdated
@jsidorenko jsidorenko marked this pull request as ready for review March 3, 2026 16:19
@jsidorenko jsidorenko requested a review from a team as a code owner March 3, 2026 16:19
ozgb
ozgb approved these changes Mar 4, 2026
View reviewed changes

@ozgb ozgb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! nit only

Comment thread util/toolkit/src/commands/generate_intent.rs Outdated
@jsidorenko jsidorenko enabled auto-merge March 4, 2026 10:42
@jsidorenko jsidorenko added this pull request to the merge queue Mar 4, 2026
Merged via the queue into main with commit a228e51 Mar 4, 2026
34 checks passed
@jsidorenko jsidorenko deleted the js/PM-22073-toolkit-pass-ledger-params branch March 4, 2026 12:37
gilescope pushed a commit that referenced this pull request Apr 8, 2026
@kpinter-iohk
docs: ETCM-9687: document partner-chains-cli (#837)
3632684
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
docs: ETCM-9687: document partner-chains-cli (#837)
7be4d7e 
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
docs: ETCM-9687: document partner-chains-cli (#837)
6d02664 
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LGLO LGLO LGLO approved these changes

@ozgb ozgb ozgb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jsidorenko @LGLO @ozgb