ci: speed up generate metadata#825
Merged
Merged
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
Contributor
|
KICS version: v2.1.19
|
Signed-off-by: Giles Cope <gilescope@gmail.com>
…t versions of node Signed-off-by: Giles Cope <gilescope@gmail.com>
ozgb
approved these changes
Mar 2, 2026
Contributor
Author
|
Running in updated CI image for rust 1.93: https://github.com/midnightntwrk/midnight-node/actions/runs/22573006125 |
gilescope
commented
Mar 2, 2026
m2ux
pushed a commit
that referenced
this pull request
Mar 2, 2026
* chore: speed up generate metadata Signed-off-by: Giles Cope <gilescope@gmail.com> * chore: remove redundent intalls (these are already in the ci image) Signed-off-by: Giles Cope <gilescope@gmail.com> * fix: stick node in CI image, use one version rather than two different versions of node Signed-off-by: Giles Cope <gilescope@gmail.com> * Apply suggestion from @gilescope --------- Signed-off-by: Giles Cope <gilescope@gmail.com>
Klapeyron
pushed a commit
that referenced
this pull request
Mar 3, 2026
* chore: speed up generate metadata Signed-off-by: Giles Cope <gilescope@gmail.com> * chore: remove redundent intalls (these are already in the ci image) Signed-off-by: Giles Cope <gilescope@gmail.com> * fix: stick node in CI image, use one version rather than two different versions of node Signed-off-by: Giles Cope <gilescope@gmail.com> * Apply suggestion from @gilescope --------- Signed-off-by: Giles Cope <gilescope@gmail.com>
gilescope
added a commit
that referenced
this pull request
Mar 3, 2026
This reverts commit 7b00a3f. Signed-off-by: Giles Cope <gilescope@gmail.com>
gilescope
pushed a commit
that referenced
this pull request
Apr 8, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
…or address (#825) Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
…or address (#825) Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Consolidates tool installations (subxt-cli, cargo-auditable, Docker-in-Docker, Node.js 22) into the CI image so they don't need to be installed on every CI run. This speeds up metadata generation and other Earthly targets by removing redundant install steps.
Key changes:
subxt-cli,cargo-auditable, and Docker intonode-ci-image-single-platformmicrodnf installcalls fromprep-no-copy,build-test-toolkit,toolkit-js-prep, andcheck-depsget-metadata,rebuild-metadata,check-metadata) now use+prep-no-copyinstead of the separate+subxtbase + DIND🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
CI will validate the Earthly targets still function correctly with the consolidated CI image.
🔱 Fork Strategy
Links
#825