feat: Bump ledgers#816
Merged
Merged
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
Contributor
Signed-off-by: Giles Cope <gilescope@gmail.com>
justinfrevert
approved these changes
Feb 28, 2026
justinfrevert
left a comment
Contributor
There was a problem hiding this comment.
Approved, assuming these versions are backwards-comptatible.
|
I'm actually shocked you were able to get git tags working here – It should have been possible to pull both from crates.io. |
gilescope
pushed a commit
that referenced
this pull request
Apr 8, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
…#816) Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
…#816) Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Overview
Bump ledger dependencies:
Fixes diamond dependency on shared crates (
base-crypto,coin-structure,midnight-serialize,transient-crypto,zkir) by giving each ledger version its own dependency tree. Concretizes fork module generics (D: DB) with concreteDb7/Db8type aliases. (We could not unify the Db trait that we were using before)🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
cargo clippy --workspace— clean (0 errors, 0 warnings)cargo test --workspace --lib— all passing (excluding pre-existing env-specific failures)Additional tests are provided (if possible)
🔱 Fork Strategy
Links