Skip to content

feat: Bump ledgers#816

Merged
gilescope merged 3 commits into
mainfrom
giles-ledger-7.0.3
Feb 28, 2026
Merged

feat: Bump ledgers#816
gilescope merged 3 commits into
mainfrom
giles-ledger-7.0.3

Conversation

@gilescope

@gilescope gilescope commented Feb 28, 2026

Copy link
Copy Markdown
Contributor

Overview

Bump ledger dependencies:

  • Ledger 7: from 7.0.2 (crates.io) to 7.0.3-rc.1 (git tag)
  • Ledger 8: from 8.0.0-rc.4 to 8.0.0-rc.5 (git tags)
  • Hard-fork test: from hard-fork-test-ledger-8.0.0-rc.4 to hard-fork-test-ledger-8.0.0-rc.5

Fixes diamond dependency on shared crates (base-crypto, coin-structure, midnight-serialize, transient-crypto, zkir) by giving each ledger version its own dependency tree. Concretizes fork module generics (D: DB) with concrete Db7/Db8 type aliases. (We could not unify the Db trait that we were using before)

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

  • cargo clippy --workspace — clean (0 errors, 0 warnings)

  • cargo test --workspace --lib — all passing (excluding pre-existing env-specific failures)

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope requested a review from a team as a code owner February 28, 2026 15:13
@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 99
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 194
Metric Values
Files scanned placeholder 31
Files parsed placeholder 31
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 10

gilescope and others added 2 commits February 28, 2026 15:18
Signed-off-by: Giles Cope <gilescope@gmail.com>

@justinfrevert justinfrevert left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, assuming these versions are backwards-comptatible.

@gilescope gilescope added this pull request to the merge queue Feb 28, 2026
Merged via the queue into main with commit 8d0e7ec Feb 28, 2026
37 checks passed
@gilescope gilescope deleted the giles-ledger-7.0.3 branch February 28, 2026 18:16
@tkerber

tkerber commented Mar 2, 2026

Copy link
Copy Markdown

I'm actually shocked you were able to get git tags working here – It should have been possible to pull both from crates.io.

m2ux added a commit that referenced this pull request Apr 23, 2026
m2ux added a commit that referenced this pull request Apr 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants