Skip to content

chore: remove dead code#811

Merged
gilescope merged 3 commits into
mainfrom
giles-remove-unused-code
Feb 27, 2026
Merged

chore: remove dead code#811
gilescope merged 3 commits into
mainfrom
giles-remove-unused-code

Conversation

@gilescope

@gilescope gilescope commented Feb 27, 2026

Copy link
Copy Markdown
Contributor

Overview

Remove the unused SyncStatusExt runtime extension, the sync-status-monitor background task, and all associated is_syncing plumbing from the node.

This code was registered as a Substrate host extension but never read by any consumer — the ledger, pallets, and runtime never call SyncStatusExt::is_syncing(). Historical UTXO ordering for preprod/preview blocks is handled by the per-transaction override data files (utxo_ordering_override.rs), which remain intact.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

cargo clippy -p midnight-node -p midnight-primitives-ledger passes cleanly.

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

Signed-off-by: Giles Cope <gilescope@gmail.com>
@github-actions

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 99
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 194
Metric Values
Files scanned placeholder 30
Files parsed placeholder 30
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 9

Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope enabled auto-merge February 27, 2026 19:50
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit 4d9b50d Feb 27, 2026
39 checks passed
@gilescope gilescope deleted the giles-remove-unused-code branch February 27, 2026 23:44
gilescope pushed a commit that referenced this pull request Apr 8, 2026
m2ux added a commit that referenced this pull request Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants