chore: remove Default impl for WalletSeed#804
Merged
Conversation
Remove the all-zero Default implementation for WalletSeed. The one internal placeholder usage in RewardsInfo is replaced with an explicit initializer.
Contributor
|
KICS version: v2.1.16
|
mpskowron
approved these changes
Feb 27, 2026
gilescope
approved these changes
Feb 27, 2026
15 tasks
m2ux
added a commit
that referenced
this pull request
Mar 27, 2026
Audit finding A2-D (Least Authority, Feb 2026): WalletSeed must not implement Default. The previous impl returned Medium([0; 32]) — an all-zero seed producing predictable wallet keys. Removed in PR #804. The compile_fail doctest ensures WalletSeed::default() does not compile, preventing re-introduction of the vulnerability. JIRA: https://shielded.atlassian.net/browse/PM-22024 Made-with: Cursor
gilescope
pushed a commit
that referenced
this pull request
Apr 8, 2026
m2ux
added a commit
that referenced
this pull request
Apr 17, 2026
Audit finding A2-D (Least Authority, Feb 2026): WalletSeed must not implement Default. The previous impl returned Medium([0; 32]) — an all-zero seed producing predictable wallet keys. Removed in PR #804. The compile_fail doctest ensures WalletSeed::default() does not compile, preventing re-introduction of the vulnerability. JIRA: https://shielded.atlassian.net/browse/PM-22024 Made-with: Cursor Signed-off-by: Mike Clay <mike.clay@shielded.io>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Apr 17, 2026
* chore: add change file for PM-22024 wallet seed audit verification Signed-off-by: Mike Clay <mike.clay@shielded.io> * chore: add PR link to change file Signed-off-by: Mike Clay <mike.clay@shielded.io> * test: add compile_fail regression test for WalletSeed Default removal Audit finding A2-D (Least Authority, Feb 2026): WalletSeed must not implement Default. The previous impl returned Medium([0; 32]) — an all-zero seed producing predictable wallet keys. Removed in PR #804. The compile_fail doctest ensures WalletSeed::default() does not compile, preventing re-introduction of the vulnerability. JIRA: https://shielded.atlassian.net/browse/PM-22024 Made-with: Cursor Signed-off-by: Mike Clay <mike.clay@shielded.io> * ci: retrigger CI after transient Docker Hub auth failure Made-with: Cursor Signed-off-by: Mike Clay <mike.clay@shielded.io> * fix: add GitHub issue reference to changes file Signed-off-by: Mike Clay <mike.clay@shielded.io> --------- Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
…#804) Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* chore: add change file for PM-22024 wallet seed audit verification * chore: add PR link to change file * test: add compile_fail regression test for WalletSeed Default removal Audit finding A2-D (Least Authority, Feb 2026): WalletSeed must not implement Default. The previous impl returned Medium([0; 32]) — an all-zero seed producing predictable wallet keys. Removed in PR #804. The compile_fail doctest ensures WalletSeed::default() does not compile, preventing re-introduction of the vulnerability. JIRA: https://shielded.atlassian.net/browse/PM-22024 Made-with: Cursor * ci: retrigger CI after transient Docker Hub auth failure Made-with: Cursor * fix: add GitHub issue reference to changes file --------- Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
…#804) Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* chore: add change file for PM-22024 wallet seed audit verification * chore: add PR link to change file * test: add compile_fail regression test for WalletSeed Default removal Audit finding A2-D (Least Authority, Feb 2026): WalletSeed must not implement Default. The previous impl returned Medium([0; 32]) — an all-zero seed producing predictable wallet keys. Removed in PR #804. The compile_fail doctest ensures WalletSeed::default() does not compile, preventing re-introduction of the vulnerability. JIRA: https://shielded.atlassian.net/browse/PM-22024 Made-with: Cursor * ci: retrigger CI after transient Docker Hub auth failure Made-with: Cursor * fix: add GitHub issue reference to changes file --------- Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Remove the all-zero Default implementation for WalletSeed. The one internal placeholder usage in RewardsInfo is replaced with an explicit initializer.
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links
https://shielded.atlassian.net/browse/PM-22087