Skip to content

Clean up governance motion handling#803

Merged
gilescope merged 8 commits into
mainfrom
fix/governance-motion-cleanup
Feb 28, 2026
Merged

Clean up governance motion handling#803
gilescope merged 8 commits into
mainfrom
fix/governance-motion-cleanup

Conversation

@justinfrevert

@justinfrevert justinfrevert commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

Ensure proposals are removed in case of a dispatch error.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

https://shielded.atlassian.net/browse/PM-22085
https://shielded.atlassian.net/browse/PM-22086

@justinfrevert
fix: clean up motion removal and member ordering in governance pallets
3653b04 
Ensure motions are always removed from storage when closed, even if
dispatch fails, to prevent stale entries.

Sort authority pairs by AccountId before unzipping into parallel
vectors so member associations stay correctly aligned.
@justinfrevert
change file
a2514f6
@justinfrevert
unused comment
d171074
@github-actions

github-actions Bot commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 99
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 194
Metric Values
Files scanned placeholder 31
Files parsed placeholder 31
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 10

@justinfrevert justinfrevert marked this pull request as ready for review February 27, 2026 03:24
@justinfrevert justinfrevert requested a review from a team as a code owner February 27, 2026 03:24
mpskowron
mpskowron approved these changes Feb 27, 2026
View reviewed changes
Comment thread pallets/federated-authority/src/lib.rs Outdated
gilescope and others added 3 commits February 28, 2026 11:32
@gilescope @mpskowron
Apply suggestion from @mpskowron
8037cd4 
Co-authored-by: mpskowron <michal.skowron@iohk.io>
@gilescope
fix: ensure that failed motion does not prevent cleanup
88460ad 
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope
chore: fmt
58d2c14 
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope enabled auto-merge February 28, 2026 12:27
@gilescope gilescope added this pull request to the merge queue Feb 28, 2026
Merged via the queue into main with commit 008266e Feb 28, 2026
38 checks passed
@gilescope gilescope deleted the fix/governance-motion-cleanup branch February 28, 2026 14:31
@m2ux m2ux mentioned this pull request Mar 13, 2026
Closed
12 tasks
@adamreynolds-io adamreynolds-io mentioned this pull request Apr 1, 2026
Closed
gilescope pushed a commit that referenced this pull request Apr 8, 2026
@skylar-simoncelli @rsporny
fix: release.yml fixes (#803)
4eae790 
* Update release.yml

* Update action.yml

---------

Co-authored-by: Radosław Sporny <404@rspo.dev>
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux @rsporny
fix: release.yml fixes (#803)
9298e2e 
* Update release.yml

* Update action.yml

---------

Co-authored-by: Radosław Sporny <404@rspo.dev>
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux @rsporny
fix: release.yml fixes (#803)
2e4f651 
* Update release.yml

* Update action.yml

---------

Co-authored-by: Radosław Sporny <404@rspo.dev>
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mpskowron mpskowron mpskowron approved these changes

Assignees

No one assigned

Labels

skip-changes-check-jira

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@justinfrevert @mpskowron @gilescope