Skip to content

chore: clean up verbose logging in toolkit and ledger helpers#802

Merged
gilescope merged 4 commits into
mainfrom
chore/clean-up-verbose-logging
Feb 28, 2026
Merged

chore: clean up verbose logging in toolkit and ledger helpers#802
gilescope merged 4 commits into
mainfrom
chore/clean-up-verbose-logging

Conversation

@justinfrevert

@justinfrevert justinfrevert commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Remove unnecessary println and dbg! calls from execute_js, contract builder, and transaction build paths.

Overview

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

https://shielded.atlassian.net/browse/PM-22084

Remove unnecessary println and dbg! calls from execute_js,
contract builder, and transaction build paths.
@github-actions

github-actions Bot commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 99
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 194
Metric Values
Files scanned placeholder 31
Files parsed placeholder 31
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 8

@justinfrevert justinfrevert marked this pull request as ready for review February 27, 2026 03:25
@justinfrevert justinfrevert requested a review from a team as a code owner February 27, 2026 03:25
Signed-off-by: Giles Cope <gilescope@gmail.com>
@gilescope gilescope enabled auto-merge February 27, 2026 22:40
@gilescope gilescope added this pull request to the merge queue Feb 27, 2026
Merged via the queue into main with commit 8930bcc Feb 28, 2026
38 checks passed
@gilescope gilescope deleted the chore/clean-up-verbose-logging branch February 28, 2026 00:51
ozgb added a commit that referenced this pull request Mar 4, 2026
Add global -v/--verbose (debug level) and -q/--quiet (warn level) flags,
with info as the default. Demote noisy per-batch fetch/compute/verify
log messages from info to debug, keeping high-level progress and
summaries at info. Restore debug-level transaction logging removed in
PR #802.
github-merge-queue Bot pushed a commit that referenced this pull request Mar 6, 2026
* feat: add --verbose and --quiet flags to toolkit CLI

Add global -v/--verbose (debug level) and -q/--quiet (warn level) flags,
with info as the default. Demote noisy per-batch fetch/compute/verify
log messages from info to debug, keeping high-level progress and
summaries at info. Restore debug-level transaction logging removed in
PR #802.

* docs: update change file

* chore: remove some unnecessary logging

* fix: update println -> info to respect --quiet

* refactor: convert println status/dry-run messages to log macros

Convert status messages to log::info!, dry-run messages to log::info!,
error output to eprintln!, and debug-level diagnostics to log::debug!.
This ensures --quiet suppresses all status output while command results
(stdout) remain unaffected.

* chore: add ticket link to change file

* chore: cargo fmt

* feat: default to text logger; add --log-json option

* docs: add change file

* fix: show all log metadata in verbose mode; fix flag conflicts

* test: fix README tests
gilescope pushed a commit that referenced this pull request Apr 8, 2026
m2ux added a commit that referenced this pull request Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants