Skip to content

fix(toolkit): use ledger_parameters.global_ttl for toolkit transactions TTL#791

Merged
LGLO merged 4 commits into
mainfrom
fix-use-global-ttl-for-toolkit-transactions
Feb 28, 2026
Merged

fix(toolkit): use ledger_parameters.global_ttl for toolkit transactions TTL#791
LGLO merged 4 commits into
mainfrom
fix-use-global-ttl-for-toolkit-transactions

Conversation

@LGLO

@LGLO LGLO commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Overview

10 minutes TTL is not enough for performance tests. Testers requested longer TTL to let transactions soak.
JIRA: https://shielded.atlassian.net/browse/PM-21976

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@LGLO LGLO requested a review from a team as a code owner February 26, 2026 07:50
@github-actions

github-actions Bot commented Feb 26, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 99
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 194
Metric Values
Files scanned placeholder 31
Files parsed placeholder 31
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 8

@LGLO LGLO changed the title fix(toolkit): use ledger_parameters.global_ttl for toolkit transactios ttl fix(toolkit): use ledger_parameters.global_ttl for toolkit transactions TTL Feb 26, 2026
@LGLO LGLO force-pushed the fix-use-global-ttl-for-toolkit-transactions branch from 4ab132a to 6b25b71 Compare February 26, 2026 16:13
@LGLO LGLO enabled auto-merge February 27, 2026 06:23
@gilescope gilescope disabled auto-merge February 27, 2026 12:35
@gilescope gilescope added this pull request to the merge queue Feb 27, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 27, 2026
@LGLO LGLO enabled auto-merge February 27, 2026 16:01
@LGLO LGLO added this pull request to the merge queue Feb 28, 2026
Merged via the queue into main with commit 06468a6 Feb 28, 2026
37 checks passed
@LGLO LGLO deleted the fix-use-global-ttl-for-toolkit-transactions branch February 28, 2026 10:10
gilescope pushed a commit that referenced this pull request Apr 8, 2026
@jankun4
add docs for smart-contract/commands crate (#791)
4519281
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
add docs for smart-contract/commands crate (#791)
64f9e66 
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
add docs for smart-contract/commands crate (#791)
548efcd 
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NachoPal NachoPal NachoPal approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LGLO @NachoPal @gilescope