ci: fix main workflow when building non-main branches#693
Merged
Conversation
Ensure sign-image.sh and free-disk-space.sh are checked out from $GITHUB_REF (the workflow commit) rather than the inputs.branch ref, so CI infrastructure always comes from the workflow version even when building a different branch.
GITHUB_REF doesn't exist as a local ref when actions/checkout checked out a different branch via inputs.branch. Fetch it from origin first, then checkout files from FETCH_HEAD.
Contributor
|
KICS version: v2.1.16
|
Remove the existence check so images are always re-pushed with proper single-arch manifests, overwriting any broken manifest lists from previous imagetools create runs.
Re-add existence check before mirroring. The previous broken manifest lists were caused by using imagetools create, which has been replaced with pull+tag+push to preserve proper single-arch manifests.
gilescope
approved these changes
Feb 22, 2026
gilescope
left a comment
Contributor
There was a problem hiding this comment.
Agreed, sbom for indexer seems the wrong place for it.
We should delete it rather than commenting it out.
gilescope
pushed a commit
that referenced
this pull request
Apr 8, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
ghcr.io/midnight-ntwrktoghcr.io/midnightntwrkif missingmidnightnwrk🗹 TODO before merging
node-0.20.2-rc.2:📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links