fix: remove non-determinism#679
Merged
Merged
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
gilescope
commented
Feb 15, 2026
Just this change would not be enough to get to head.
justinfrevert
approved these changes
Feb 15, 2026
justinfrevert
left a comment
Contributor
There was a problem hiding this comment.
Seems like it should improve things.
ozgb
pushed a commit
that referenced
this pull request
Feb 18, 2026
* fix: keep existing preview ordering Signed-off-by: Giles Cope <gilescope@gmail.com> * preview has other tx with different orderings. Just this change would not be enough to get to head. * fix npm audit finding --------- Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com>
14 tasks
ozgb
pushed a commit
that referenced
this pull request
Feb 18, 2026
* fix: keep existing preview ordering Signed-off-by: Giles Cope <gilescope@gmail.com> * preview has other tx with different orderings. Just this change would not be enough to get to head. * fix npm audit finding --------- Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com>
14 tasks
ozgb
added a commit
that referenced
this pull request
Feb 18, 2026
* chore: update indexer commit to fix sbom checks * feat: add network_peerReputations and network_peerReputation RPC endpoints (#649) * feat: add network_peerReputations and network_peerReputation RPC endpoints Expose peer reputation and ban status via JSON-RPC to enable debugging peer connectivity issues without custom tooling. * docs: update change file * chore: cargo fmt --------- Co-authored-by: Squirrel <giles.cope@shielded.io> * feat: add unsafe RPC to unban peers (#666) * feat: add unsafe RPC to unban peers Useful for node operators to use when a peer is banned but has since corrected it’s behaviour. Without this RPC, the only way to reset peer reputation is to restart the node (reputation exists in memory only). * docs: add pr link to change file * fix: remove non-determinism (#679) * fix: keep existing preview ordering Signed-off-by: Giles Cope <gilescope@gmail.com> * preview has other tx with different orderings. Just this change would not be enough to get to head. * fix npm audit finding --------- Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com> * fix: sync non-deterministically while historical chain patch is pending (#685) * fix: sync non-deterministically while historical chain patch is pending * docs: add pr link to change file * docs: add ticket link to change file * chore: cargo fmt --------- Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Squirrel <giles.cope@shielded.io> Co-authored-by: Justin Frevert <justinfrevert@gmail.com>
ozgb
added a commit
that referenced
this pull request
Feb 18, 2026
* fix: remove non-determinism (#679) * fix: keep existing preview ordering Signed-off-by: Giles Cope <gilescope@gmail.com> * preview has other tx with different orderings. Just this change would not be enough to get to head. * fix npm audit finding --------- Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com> * fix: sync non-deterministically while historical chain patch is pending (#685) * fix: sync non-deterministically while historical chain patch is pending * docs: add pr link to change file * docs: add ticket link to change file * feat: add unsafe RPC to unban peers (#666) * feat: add unsafe RPC to unban peers Useful for node operators to use when a peer is banned but has since corrected it’s behaviour. Without this RPC, the only way to reset peer reputation is to restart the node (reputation exists in memory only). * docs: add pr link to change file --------- Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Squirrel <giles.cope@shielded.io> Co-authored-by: Justin Frevert <justinfrevert@gmail.com>
gilescope
pushed a commit
that referenced
this pull request
Apr 8, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a hashmap, unshielded tx with 1 input have a deterministic iteration, but for unsigned tx with more than one input then it's non-deterministic.
Ensure deterministic ordering. This order might be a tad peculiar but it gets past the 6xx block that was the first to cause issues.
How did I find it:
I was syncing with preview. 80% of the time I was getting panics - I guess the true figure was 75% of the time because there are 2 hashmaps and with 2 entries in them you get 4 combos. When I switched to the btreemap I got panics every time I got to that block. When I did rev on both inputs and outputs I got panics all the time , but when rev inputs and not outputs then every time I got past the 634 block on preview.
#679