switch to collection with deterministic iteration.#678
Merged
Conversation
Signed-off-by: Giles Cope <gilescope@gmail.com>
Contributor
|
KICS version: v2.1.16
|
Signed-off-by: Giles Cope <gilescope@gmail.com>
NachoPal
approved these changes
Feb 16, 2026
Signed-off-by: Giles Cope <gilescope@gmail.com>
NachoPal
pushed a commit
that referenced
this pull request
Feb 16, 2026
* switch to collection with deterministic iteration. Signed-off-by: Giles Cope <gilescope@gmail.com> * fix: keep existing preview ordering Signed-off-by: Giles Cope <gilescope@gmail.com> * chore: add changelog Signed-off-by: Giles Cope <gilescope@gmail.com> --------- Signed-off-by: Giles Cope <gilescope@gmail.com>
gilescope
added a commit
that referenced
this pull request
Mar 11, 2026
* feat: add deterministic runtime builds * chore: update change file * fix: srtool target clean-up * chore: updare to new mainnet values * set cnight to empty for testing * switch to collection with deterministic iteration. (#678) * switch to collection with deterministic iteration. Signed-off-by: Giles Cope <gilescope@gmail.com> * fix: keep existing preview ordering Signed-off-by: Giles Cope <gilescope@gmail.com> * chore: add changelog Signed-off-by: Giles Cope <gilescope@gmail.com> --------- Signed-off-by: Giles Cope <gilescope@gmail.com> * fix: genesis timestamp * granular generation * mainnet chain-spec * feat: local db-sync + cnigh-config working * filter cnight-config * docs: update * backup * remove temporarily SBOM * temporarily disable sbom in release * feat: add genesis message placeholder * fix: asset name encoding * fix: policy_id decoding * fix: ics and reserve queries * fix conflicts * chain-spec regenerated * fix: add --no-cache to earthly for genesis * feat: make verification steps skippable * fix: enable all verification for mainnet * feat: add genesis message * fix: make clippy happy * fix: genesis message * feat: add bootnodes config file * feat: check fees * add change file + nits * chore: remove mainnet generated files * docs: update with bootnodes info * address comments * update mainnet cardano-tip * regenerate mainner config * fix: perfnet build genesis --------- Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Squirrel <giles.cope@shielded.io> Signed-off-by: Giles Cope <gilescope@gmail.com>
github-merge-queue Bot
pushed a commit
that referenced
this pull request
Mar 12, 2026
* feat: add deterministic runtime builds * chore: update change file * fix: srtool target clean-up * chore: updare to new mainnet values * set cnight to empty for testing * switch to collection with deterministic iteration. (#678) * switch to collection with deterministic iteration. Signed-off-by: Giles Cope <gilescope@gmail.com> * fix: keep existing preview ordering Signed-off-by: Giles Cope <gilescope@gmail.com> * chore: add changelog Signed-off-by: Giles Cope <gilescope@gmail.com> --------- Signed-off-by: Giles Cope <gilescope@gmail.com> * fix: genesis timestamp * granular generation * mainnet chain-spec * feat: local db-sync + cnigh-config working * filter cnight-config * docs: update * backup * remove temporarily SBOM * temporarily disable sbom in release * feat: add genesis message placeholder * fix: asset name encoding * fix: policy_id decoding * fix: ics and reserve queries * fix conflicts * chain-spec regenerated * fix: add --no-cache to earthly for genesis * feat: make verification steps skippable * fix: enable all verification for mainnet * feat: add genesis message * fix: make clippy happy * fix: genesis message * feat: add bootnodes config file * feat: check fees * add change file + nits * chore: remove mainnet generated files * docs: update with bootnodes info * address comments * update mainnet cardano-tip * regenerate mainner config * fix: perfnet build genesis * fix --------- Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Squirrel <giles.cope@shielded.io>
gilescope
pushed a commit
that referenced
this pull request
Apr 8, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Breaking change: switch to collection with deterministic iteration.
This will not sync existing non-deterministic chains. The previous hashmap would sync eventually though it would be inefficient and panic when not the right ordering picked.
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links