ci: fix release assets signing#672
Merged
Merged
Conversation
…lity Cosign v2.4+ (installed via cosign-installer@v4.0.0) requires the --bundle flag with sign-blob. Without it, signing fails with "must provide --bundle with --signing-config or --use-signing-config".
The signing script checkout was using inputs.ref (the release branch), which still had the old script without --bundle. CI utilities should come from the workflow's own branch to pick up fixes immediately.
Cosign v2.4+ only writes the .bundle file and silently ignores --output-signature/--output-certificate. Switch to .bundle as the sole signing artifact, which is the standard Sigstore format.
Use IMAGE_TAG instead of RELEASE_TAG for filenames to avoid "midnight-node-node-" and "midnight-node-toolkit-node-" prefixes.
Same fix as for the binary signing script checkout — CI utilities should come from the workflow's own branch to pick up fixes.
Contributor
|
KICS version: v2.1.16
|
10 tasks
KrisF-Midnight
approved these changes
Feb 13, 2026
gilescope
approved these changes
Feb 14, 2026
gilescope
pushed a commit
that referenced
this pull request
Apr 8, 2026
added: - guaranteed seats tests - seats distribution matching DParam tests changed: - participation tolerance will use absolute value if calculated one is too small Refs: ETCM-8934
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
added: - guaranteed seats tests - seats distribution matching DParam tests changed: - participation tolerance will use absolute value if calculated one is too small Refs: ETCM-8934 Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
added: - guaranteed seats tests - seats distribution matching DParam tests changed: - participation tolerance will use absolute value if calculated one is too small Refs: ETCM-8934 Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Fixes the release workflow with the following:
.bundlerather than separate.pemand.sigfilesinputs.refrather than workflow branch for CI-only files-nodein release assets filenameRun for 0.22.0-rc.1 here: https://github.com/midnightntwrk/midnight-node/actions/runs/21990734816
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links