protect against missing t and c values at genesis#646
Merged
Conversation
Contributor
|
KICS version: v2.1.16
|
gilescope
approved these changes
Feb 11, 2026
Signed-off-by: Giles Cope <gilescope@gmail.com>
Signed-off-by: Giles Cope <gilescope@gmail.com>
Merged
14 tasks
m2ux
added a commit
that referenced
this pull request
Apr 13, 2026
Add three tests to pallet-system-parameters verifying that genesis build panics when Terms and Conditions inputs are incomplete: - genesis_panics_with_hash_only (URL missing) - genesis_panics_with_url_only (hash missing) - genesis_panics_with_no_terms_and_conditions (both missing) These tests cover the fail-fast .expect() validation added in PR #646 and satisfy the Least Authority audit remediation requirement (PM-22033).
m2ux
added a commit
that referenced
this pull request
Apr 13, 2026
Add three tests to pallet-system-parameters verifying that genesis build panics when Terms and Conditions inputs are incomplete: - genesis_panics_with_hash_only (URL missing) - genesis_panics_with_url_only (hash missing) - genesis_panics_with_no_terms_and_conditions (both missing) These tests cover the fail-fast .expect() validation added in PR #646 and satisfy the Least Authority audit remediation requirement (PM-22033). Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Minhcardanian
pushed a commit
to Minhcardanian/midnight-node
that referenced
this pull request
Apr 23, 2026
…s input (PM-22033) (midnightntwrk#1215) * chore: initialize branch for PM-22033 partial terms conditions genesis validation Made-with: Cursor Signed-off-by: Mike Clay <mike.clay@shielded.io> * chore: initialize branch for PM-22033 partial terms conditions genesis validation Made-with: Cursor Signed-off-by: Mike Clay <mike.clay@shielded.io> * test: add #[should_panic] tests for partial T&C genesis validation Add three tests to pallet-system-parameters verifying that genesis build panics when Terms and Conditions inputs are incomplete: - genesis_panics_with_hash_only (URL missing) - genesis_panics_with_url_only (hash missing) - genesis_panics_with_no_terms_and_conditions (both missing) These tests cover the fail-fast .expect() validation added in PR midnightntwrk#646 and satisfy the Least Authority audit remediation requirement (PM-22033). Signed-off-by: Mike Clay <mike.clay@shielded.io> * Apply lech's suggestion * fix: correct test for T&C without D-parameter per LGLO review Signed-off-by: Mike Clay <mike.clay@shielded.io> Made-with: Cursor --------- Signed-off-by: Mike Clay <mike.clay@shielded.io> Co-authored-by: Squirrel <giles.cope@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links