Skip to content

feat: add workflow for signing release binaries#577

Merged
tgunnoe merged 1 commit into
mainfrom
feat/signed-binaries
Feb 10, 2026
Merged

feat: add workflow for signing release binaries#577
tgunnoe merged 1 commit into
mainfrom
feat/signed-binaries

Conversation

@tgunnoe

@tgunnoe tgunnoe commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Overview

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@tgunnoe tgunnoe force-pushed the feat/signed-binaries branch from b099368 to 62b90e2 Compare January 30, 2026 18:21
@github-actions

github-actions Bot commented Jan 30, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

kics-logo

KICS version: v2.1.16

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 96
LOW LOW 12
INFO INFO 83
TRACE TRACE 0
TOTAL TOTAL 191
Metric Values
Files scanned placeholder 31
Files parsed placeholder 31
Files failed to scan placeholder 0
Total executed queries placeholder 73
Queries failed to execute placeholder 0
Execution time placeholder 8

mladen-shielded
mladen-shielded reviewed Feb 2, 2026
View reviewed changes
Comment thread .github/workflows/release-image.yml
Comment thread .github/workflows/release-image.yml
@tgunnoe tgunnoe force-pushed the feat/signed-binaries branch from 62b90e2 to a932ffd Compare February 5, 2026 15:54
github-advanced-security[bot]
github-advanced-security AI found potential problems Feb 5, 2026
View reviewed changes
Comment thread .github/workflows/release-image.yml Fixed
Comment thread .github/workflows/release-image.yml Fixed
@tgunnoe tgunnoe force-pushed the feat/signed-binaries branch 2 times, most recently from 9a92a84 to 0b68aa0 Compare February 5, 2026 17:13
@tgunnoe tgunnoe marked this pull request as ready for review February 5, 2026 17:15
@tgunnoe tgunnoe requested a review from a team as a code owner February 5, 2026 17:15
@CLAassistant

CLAassistant commented Feb 5, 2026 •
edited
Loading

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@tgunnoe

tgunnoe commented Feb 9, 2026

Copy link
Copy Markdown
Contributor Author

here's the binary signing result: https://github.com/midnightntwrk/midnight-node/releases/tag/node-0.21.0-signing-test
the job https://github.com/midnightntwrk/midnight-node/actions/runs/21830317009/job/62987467476

@tgunnoe tgunnoe force-pushed the feat/signed-binaries branch from 0b68aa0 to f0007d2 Compare February 9, 2026 15:19
@tgunnoe tgunnoe added this pull request to the merge queue Feb 10, 2026
Merged via the queue into main with commit 56781ed Feb 10, 2026
38 of 39 checks passed
@tgunnoe tgunnoe deleted the feat/signed-binaries branch February 10, 2026 16:05
@tgunnoe tgunnoe mentioned this pull request Feb 11, 2026
Merged
14 tasks
gilescope pushed a commit that referenced this pull request Apr 8, 2026
@AmbientTea
change: Cleanup cli commands crate (#577)
6c18056
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
change: Cleanup cli commands crate (#577)
7a7f7de 
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
change: Cleanup cli commands crate (#577)
cd7ff4d 
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@justinfrevert justinfrevert justinfrevert approved these changes

@mladen-shielded mladen-shielded Awaiting requested review from mladen-shielded

@KrisF-Midnight KrisF-Midnight Awaiting requested review from KrisF-Midnight

Assignees

No one assigned

Labels

skip-changes-check-all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tgunnoe @CLAassistant @github-advanced-security @justinfrevert @mladen-shielded @KrisF-Midnight