feat: open source node by gilescope · Pull Request #2 · midnightntwrk/midnight-node

gilescope · 2025-05-29T13:05:31Z

Take 1: Open source node.

github-actions · 2025-05-29T13:08:48Z

Checkmarx One – Scan Summary & Details – 05993dd7-749c-4f05-a7e1-41cff6092a2a

New Issues (64)

Checkmarx found the following issues in this Pull Request

Issue	Source File / Package	Checkmarx Insight
Container Capabilities Unrestricted	/fork-test-compose.yml: 35	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: Q3HA07oRqNqOiD4Fc%2FLYGvxUoZU%3D`
Container Capabilities Unrestricted	/test-compose.yml: 2	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: FBUCZiSa02Uzqnb8qsiMsBCAJ6Q%3D`
Container Capabilities Unrestricted	/fork-test-compose.yml: 70	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: vWy9BXGm2h11pzL0yk7%2FIG%2Flemw%3D`
Container Capabilities Unrestricted	/test-compose-latest.yml: 2	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: ChmchZrUAWATKVq%2FD3ILNqgci7k%3D`
Container Capabilities Unrestricted	/fork-test-compose.yml: 134	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: OFO9I4m5Ixkp7gjVJ2LpM49%2B5NU%3D`
Container Capabilities Unrestricted	/fork-test-compose.yml: 118	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: q1SQP%2Bw5FKruNDwGikShvIAld%2BE%3D`
Container Capabilities Unrestricted	/fork-test-compose.yml: 86	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: tDg9MdRBoNyyxDfiUgAXJ4CbfoM%3D`
Container Capabilities Unrestricted	/fork-test-compose.yml: 168	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: qbBKj8KzNDhNn2coPr8liZsunZ4%3D`
Container Capabilities Unrestricted	/fork-test-compose.yml: 54	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: EDMGpoe9HyhoSJ9IAopUXlTRnWw%3D`
Container Capabilities Unrestricted	/fork-test-compose.yml: 150	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: 7qgfWZLjEq9LoTcWQp7uip5JP24%3D`
Container Capabilities Unrestricted	/fork-test-compose.yml: 102	details Some capabilities are not needed in certain (or any) containers. Make sure that you only add capabilities that your container needs. Drop unnec... `ID: VAkJSLR5VFPNnPQx%2Bh5z4BixzzY%3D`
Container Traffic Not Bound To Host Interface	/fork-test-compose.yml: 157	details Incoming container traffic should be bound to a specific host interface `ID: HOG%2B3p0VxXSf9NqbBJLJ0LbxSMo%3D`
Container Traffic Not Bound To Host Interface	/fork-test-compose.yml: 56	details Incoming container traffic should be bound to a specific host interface `ID: BcpXnOQz9Fnb5Ffx9tpgIQrg35M%3D`
Container Traffic Not Bound To Host Interface	/test-compose-latest.yml: 4	details Incoming container traffic should be bound to a specific host interface `ID: zYxSJHbPoO4pYi%2FD3BIZ3tmrmQ4%3D`
Container Traffic Not Bound To Host Interface	/fork-test-compose.yml: 141	details Incoming container traffic should be bound to a specific host interface `ID: 35hrkRKm%2F%2FHyhAcR%2BM0rosIXbXQ%3D`
Container Traffic Not Bound To Host Interface	/test-compose.yml: 4	details Incoming container traffic should be bound to a specific host interface `ID: 75PCcqN7tdB38Fbqilp4z3frvBg%3D`
Container Traffic Not Bound To Host Interface	/fork-test-compose.yml: 109	details Incoming container traffic should be bound to a specific host interface `ID: AWPCswZ8oeJi0NqMN1PcqRFvnp8%3D`
Container Traffic Not Bound To Host Interface	/fork-test-compose.yml: 77	details Incoming container traffic should be bound to a specific host interface `ID: rijY4GbNkm2p8MLO10z5%2BCu1e1g%3D`
Container Traffic Not Bound To Host Interface	/fork-test-compose.yml: 40	details Incoming container traffic should be bound to a specific host interface `ID: nkbOzb1ToZTTDiYMOsFHpkwkgpo%3D`
Container Traffic Not Bound To Host Interface	/fork-test-compose.yml: 125	details Incoming container traffic should be bound to a specific host interface `ID: 3%2FO0%2B0W6OMBgzQmgEgWFOi5vCpo%3D`
Container Traffic Not Bound To Host Interface	/fork-test-compose.yml: 93	details Incoming container traffic should be bound to a specific host interface `ID: 59iGAEnoXD2gxQDn%2BUmD%2BGwSNVU%3D`
Healthcheck Not Set	/fork-test-compose.yml: 102	details Check containers periodically to see if they are running properly. `ID: g7NQ2yapI9Vdn7tVWNmIn7GB2yE%3D`
Healthcheck Not Set	/fork-test-compose.yml: 54	details Check containers periodically to see if they are running properly. `ID: II2H5%2Fjif4jLMBQWFO9YU9wyUDM%3D`
Healthcheck Not Set	/fork-test-compose.yml: 70	details Check containers periodically to see if they are running properly. `ID: f3nKgedKNLICkMtp3gqtcjl0MG0%3D`
Healthcheck Not Set	/fork-test-compose.yml: 150	details Check containers periodically to see if they are running properly. `ID: OwxW2Mk0HzoD0218fBPeNrS6U6Q%3D`
Healthcheck Not Set	/fork-test-compose.yml: 168	details Check containers periodically to see if they are running properly. `ID: EVxAZFgQJgHvp8FkuDFLriyMKEg%3D`
Healthcheck Not Set	/fork-test-compose.yml: 86	details Check containers periodically to see if they are running properly. `ID: Kr3BpyzZfVSqeFcPN%2FNp000Csb4%3D`
Healthcheck Not Set	/fork-test-compose.yml: 118	details Check containers periodically to see if they are running properly. `ID: pDUpW7iW9Vymf4fKnSDuB545twI%3D`
Healthcheck Not Set	/fork-test-compose.yml: 134	details Check containers periodically to see if they are running properly. `ID: eEEkOL%2BNEDbIUpiyfrGw5I5%2BBBc%3D`
Memory Not Limited	/fork-test-compose.yml: 150	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: 1N9B5OsWgvveN2GuyL5O848d1N0%3D`
Memory Not Limited	/fork-test-compose.yml: 134	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: pjXXo7Yp2cE5Wtky%2BXzF%2Bi3B77o%3D`
Memory Not Limited	/fork-test-compose.yml: 168	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: cejIOhoPMwZQK16%2FAayTsbtV7pw%3D`
Memory Not Limited	/fork-test-compose.yml: 70	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: 7v65i7ts4b6traMROeudtSOAXOU%3D`
Memory Not Limited	/fork-test-compose.yml: 86	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: 53%2B9lOwAlbCtTqxasUY3LZnncEI%3D`
Memory Not Limited	/fork-test-compose.yml: 35	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: GQWxl7yL6Dt4Ngn3ZGWM8QYMSWE%3D`
Memory Not Limited	/fork-test-compose.yml: 102	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: WiW9qfBrY6AhWwFZwjW6brJh3Ts%3D`
Memory Not Limited	/fork-test-compose.yml: 54	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: HU8tz5pJ%2Fx2xwOJVNN%2BqJ8Sdy68%3D`
Memory Not Limited	/fork-test-compose.yml: 118	details Memory limits should be defined for each container. This prevents potential resource exhaustion by ensuring that containers consume not more than ... `ID: %2B16OwHVNPe5w7lUqUJxy2y8RrIc%3D`
Security Opt Not Set	/test-compose.yml: 2	details Attribute 'security_opt' should be defined. `ID: qyNeUebY0pe1%2BJfF%2FIrcYWe%2BaRM%3D`
Security Opt Not Set	/fork-test-compose.yml: 150	details Attribute 'security_opt' should be defined. `ID: O7DV3N6CcFtVYkp46BRnGVMX7xE%3D`
Security Opt Not Set	/test-compose-latest.yml: 2	details Attribute 'security_opt' should be defined. `ID: NfhnF%2FsxIvLoJ4H0dWGus7aaeyg%3D`
Security Opt Not Set	/fork-test-compose.yml: 118	details Attribute 'security_opt' should be defined. `ID: 5jw1HMKDCpD7EMjIdEAIICslbfw%3D`
Security Opt Not Set	/fork-test-compose.yml: 102	details Attribute 'security_opt' should be defined. `ID: 939LnL5yK%2F3qfT34ZAeCrev0XFc%3D`
Security Opt Not Set	/fork-test-compose.yml: 86	details Attribute 'security_opt' should be defined. `ID: bdd8BnHIclk1w%2Be3DHZsi8rwaco%3D`
Security Opt Not Set	/fork-test-compose.yml: 134	details Attribute 'security_opt' should be defined. `ID: 7lhmYmmX7dXEBGPGQjNp3XFIj3s%3D`
Security Opt Not Set	/fork-test-compose.yml: 70	details Attribute 'security_opt' should be defined. `ID: hDRmSq0NDQzIUQLZd05PspbfejI%3D`
Security Opt Not Set	/fork-test-compose.yml: 54	details Attribute 'security_opt' should be defined. `ID: kAzDyEj9Jm9Cz%2BLPuu7O4qMK2kc%3D`
Security Opt Not Set	/fork-test-compose.yml: 168	details Attribute 'security_opt' should be defined. `ID: RUreJwngXzxVW4ATKaEDNKcFxRs%3D`
Security Opt Not Set	/fork-test-compose.yml: 35	details Attribute 'security_opt' should be defined. `ID: fJ6vdVOtRsywG9XmUFoE7M7EjQA%3D`
Cpus Not Limited	/fork-test-compose.yml: 168	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: JBK8KK%2B0FiYygYWWITnkBOFXBzU%3D`
Cpus Not Limited	/fork-test-compose.yml: 54	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: zsbIu8f%2BrWwNHTzHHTx%2F2cXwr1o%3D`
Cpus Not Limited	/fork-test-compose.yml: 118	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: t2XfjN%2B8Mwhv9M27lTqe1NVV9dA%3D`
Cpus Not Limited	/fork-test-compose.yml: 70	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: w6ToqSj4Hb5Ty%2FMxnkaU9IJBluw%3D`
Cpus Not Limited	/fork-test-compose.yml: 102	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: %2B68V2HAdIKRKskaj57ncFVjGius%3D`
Cpus Not Limited	/fork-test-compose.yml: 134	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: 8koSpysPxhYQlfGYJQryeKJYJ1A%3D`
Cpus Not Limited	/fork-test-compose.yml: 86	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: awq%2F%2BNz8cP3Wa0VMQQIFUmjRVwU%3D`
Cpus Not Limited	/fork-test-compose.yml: 150	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: uQh68aWtPElUmgBwJ8nmH15DpFg%3D`
Cpus Not Limited	/fork-test-compose.yml: 35	details CPU limits should be set because if the system has CPU time free, a container is guaranteed to be allocated as much CPU as it requests `ID: %2BBFcVGxFnZr1YwkSHkIENPPoZ%2BE%3D`
Unpinned Actions Full Length Commit SHA	/local-environment-tests.yml: 41	details Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help... `ID: fijCa6j5C6V4%2BMmSz174rZyXnWw%3D`
Unpinned Actions Full Length Commit SHA	/nightly-build-check.yml: 41	details Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help... `ID: Q%2BMd4sYqyMCOlRpCuNPedw1xBEk%3D`
Unpinned Actions Full Length Commit SHA	/nightly-build-check.yml: 30	details Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help... `ID: aCZHR1qu5FOfbqLwbXQfQLvZXSg%3D`
Unpinned Actions Full Length Commit SHA	/nightly-build-check.yml: 48	details Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help... `ID: MglGwwFwZmNcOhpKUSkyvZpnvD8%3D`
Unpinned Actions Full Length Commit SHA	/nightly-build-check.yml: 23	details Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help... `ID: JEbk13rO5zyn0V6%2BfwdFNO6BgnQ%3D`
Unpinned Actions Full Length Commit SHA	/nightly-build-check.yml: 36	details Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA help... `ID: rtZPDYVBukDflQ4ZqHU6YQFF6fM%3D`

Signed-off-by: Matti Blecher <matti.blecher@iohk.io>

# This is the 1st commit message: backup # This is the commit message #2: feat: improve inherent

Signed-off-by: Mike Clay <mike.clay@shielded.io>

The wallet_registry circuit was recompiled in the parent repo without --no-communications-commitment so its proof satisfies the chain's ContractCall::public_inputs (which unconditionally pushes communication_commitment as PI midnightntwrk#2). The new register.verifier changes the deploy address: 0xeccaa2cb...e79c80 -> 0xbff186ce...c387b946. The genesis-time deploy reads circuits/static/wallet-registry/register.verifier via include_bytes!, so regenerating genesis with the parent repo's new artifact picks up the new key. The fixed nonce keeps the address deterministic (load-bearing only on the verifier bytes + initial state layout, both content-versioned via the compact source).

feat: open source node

a7b0336

gilescope requested review from a team as code owners May 29, 2025 13:05

gilescope added the skip-changes-check-all label May 29, 2025

Update changes_check.yml

d7b05e9

Signed-off-by: Matti Blecher <matti.blecher@iohk.io>

gilescope closed this May 31, 2025

gilescope deleted the giles-open-source-node branch June 3, 2025 08:15

NachoPal added a commit that referenced this pull request Dec 15, 2025

# This is a combination of 2 commits.

30708cc

# This is the 1st commit message: backup # This is the commit message #2: feat: improve inherent

This was referenced Feb 26, 2026

ci: Stop spamming server with intermediate builds. #781

Merged

feat: check memory headroom #771

Merged

gilescope pushed a commit that referenced this pull request Apr 8, 2026

fix: remove running docker images from docs, fix local docker build (#2)

b27aabd

chrispalaskas mentioned this pull request Apr 13, 2026

Remove logging completely for unregistered cnight operations #1324

Merged

14 tasks

m2ux added a commit that referenced this pull request Apr 23, 2026

fix: remove running docker images from docs, fix local docker build (#2)

330f9fd

Signed-off-by: Mike Clay <mike.clay@shielded.io>

m2ux added a commit that referenced this pull request Apr 23, 2026

fix: remove running docker images from docs, fix local docker build (#2)

56de5d5

Signed-off-by: Mike Clay <mike.clay@shielded.io>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: open source node#2

feat: open source node#2
gilescope wants to merge 2 commits into
mainfrom
giles-open-source-node

gilescope commented May 29, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented May 29, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

gilescope commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented May 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gilescope commented May 29, 2025 •

edited

Loading

github-actions Bot commented May 29, 2025 •

edited

Loading