Update cNight Observation for new Datum structure by ozgb · Pull Request #189 · midnightntwrk/midnight-node

ozgb · 2025-10-29T17:02:39Z

Overview

Updates the cNight observation pallet and inherent data provider to support new contracts

Feature ticket:

https://shielded.atlassian.net/browse/PM-20020

Fixes:

🗹 TODO before merging

Ready
Rename cardano_address to something more specific
Wrap the byte array types in Structs
e2e tests

📌 Submission Checklist

Changes are backward-compatible (or flagged if breaking)
Pull request description explains why the change is needed
Self-reviewed the diff
I have included a change file, or skipped for this reason:
If the changes introduce a new feature, I have bumped the node minor version
Update documentation (if relevant)
No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

Additional tests are provided (if possible)

🔱 Fork Strategy

Node Runtime Update
Node Client Update
Other:
N/A

Links

github-actions · 2025-10-29T17:05:22Z

Checkmarx One – Scan Summary & Details – ca202927-83ac-43eb-b917-e33aee6a37f5

Fixed Issues (3)

Great job! The following issues were fixed in this Pull Request

Severity	Issue	Source File / Package
	~~CVE-2024-53384~~	Npm-tsup-8.5.0
	~~CVE-2025-58751~~	Npm-vite-7.0.0-beta.2
	~~CVE-2025-58752~~	Npm-vite-7.0.0-beta.2

* feat: update to follow new datum structure * test: fix tests * fix: DustPublicKey deserialized correctly (PM-19983); fix test * fix: check for DustPublicKey length; Fix missing dereg event (PM-20229) * refactor: rename types - more precise naming * refactor: rename fields for precision * feat: wrap cnight array types in new structs * feat: use McBlockHash and TxBlockHash in more places * fix: clippy warnings * docs: add change file * docs: add change file * docs: add change file * build: remove unused dep serde_arrays * chore: update metadata * feat: rename MappingEntry utxo_id -> utxo_tx_hash * feat: update type of utxo_tx_hash * feat: change type of cmst block hash * feat: add check for mapping validator auth token * chore: update sqlx cache * test: fix tests for cnight config validation * chore: update cnight config files * test: use aiken cnight smart contracts * fix: use new mapping validator address * chore: update metadata * test: fix tests after cnight pallet update * test: fix more tests, 2 e2e tests still failing * test: fix mint cnight tx budget * test: remove old typescript local-env tests * build: remove leftover target * build: remove leftover target --------- Co-authored-by: Radosław Sporny <404@rspo.dev>

#189) (#225) * Update cNight Observation for new Datum structure (#189) * feat: update to follow new datum structure * test: fix tests * fix: DustPublicKey deserialized correctly (PM-19983); fix test * fix: check for DustPublicKey length; Fix missing dereg event (PM-20229) * refactor: rename types - more precise naming * refactor: rename fields for precision * feat: wrap cnight array types in new structs * feat: use McBlockHash and TxBlockHash in more places * fix: clippy warnings * docs: add change file * docs: add change file * docs: add change file * build: remove unused dep serde_arrays * chore: update metadata * feat: rename MappingEntry utxo_id -> utxo_tx_hash * feat: update type of utxo_tx_hash * feat: change type of cmst block hash * feat: add check for mapping validator auth token * chore: update sqlx cache * test: fix tests for cnight config validation * chore: update cnight config files * test: use aiken cnight smart contracts * fix: use new mapping validator address * chore: update metadata * test: fix tests after cnight pallet update * test: fix more tests, 2 e2e tests still failing * test: fix mint cnight tx budget * test: remove old typescript local-env tests * build: remove leftover target * build: remove leftover target --------- Co-authored-by: Radosław Sporny <404@rspo.dev> * chore: rebuild chainspecs --------- Co-authored-by: Radosław Sporny <404@rspo.dev>

* fix: error when loading chain spec for non-dev cfg_preset (#187) (#194) * fix: error when loading chain spec for non-dev cfg_preset --------- Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Co-authored-by: Squirrel <giles.cope@shielded.io> * chore: PC 1.8 deployment fixes (#201) * chore: node-dev-01 new chain spec with PC 1.8 registrations (#191) * chore: PC 1.8 new registrations (#197) * chore: PC 1.8 new registrations * chore: add governance info * chore: fix chain-spec to match PC 1.8 registration (#200) * Cherry pick: bump to ledger ledger-6.1.0-alpha.5 (#203) (#204) * bump to ledger ledger-6.1.0-alpha.5 (#203) (cherry picked from commit b3fac93) * Change GITHUB_TOKEN to GHP_TOKEN in workflow --------- Co-authored-by: Fenton Haslam <50406962+Fentonhaslam@users.noreply.github.com> * Backport gov (#206) * Fix: Federated Authority configurations (#180) * fix federated authorities for qanet and node-dev-01 * chore: regenerate chain_specs * fix: rebuild preview chainspec --------- Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> * [0.18.0 cherry-pick] Add midnight_ prefix to chain ID to follow Polkadot convention (#216) * Add `midnight_` prefix to chain ID to follow Polkadot convention (#188) * feat: add 'midnight_' prefix to all chain ids Network ID is created as a transformation of the chain id * chore: rebuild chainspecs * docs: add change file * feat: add check on network_id spec conformity * chore: rebuild chainspecs * Backport #142 (#220) * Feat: Federated Authority Observation - querying `db-sync` (#142) * feat: query governance data * test: e2e tests base for governance contracts * feat: adding governance contracts to local-env * aaarrrgggg deploy failing * feat: Governance contracts deployed to local-env * federate-authority-configs updated with expected contracts * feat: new members properly read from the minted nft * chore: clean up * feat: add new calls to set addresses and policy_id + benchmarks * nit * chore: make clippy happy * chore: add change file * feat: replace vec by PolicyId and MainchainAddress * chore: regenerate metadata * chore: make clippy happy * test: add test for contracts info setters * chore: update federated configs with preview real data + test fix * chore: regenerate metadata * chore: rebuild metadata * chore: rebuild chain_specs * [cherry-pick 0.18.0] Deduplicate Mapping types (#166) (#221) * Deduplicate Mapping types (#166) * chore: replace Mapping with MappingEntry Signed-off-by: yHSJ <josh@securitybot.info> * chore: changefile * chore: remove unnecessary conversions * fix: regenerate metadata * chore: update metadata * Add change tag * test: fix test compile errors --------- Signed-off-by: yHSJ <josh@securitybot.info> Co-authored-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com> * chore: rebuild metadata * chore: rebuild chainspecs --------- Signed-off-by: yHSJ <josh@securitybot.info> Co-authored-by: Joshua Marchand (JSHy) <79121297+yHSJ@users.noreply.github.com> Co-authored-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com> * Fix node entrypoint (#217) * fix node entrypoint * test * last try * fix: node entrypoint passing `--` as an arg Found when running with SHOW_CONFIG=1: ``` NAME: args HELP: The arguments passed to the node TYPE: Vec < String > DEFAULT: SOURCES: cli CURRENT_VALUE: "--, " ``` --------- Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * [cherry-pick 0.18.0] Update cNight Observation for new Datum structure (#189) (#225) * Update cNight Observation for new Datum structure (#189) * feat: update to follow new datum structure * test: fix tests * fix: DustPublicKey deserialized correctly (PM-19983); fix test * fix: check for DustPublicKey length; Fix missing dereg event (PM-20229) * refactor: rename types - more precise naming * refactor: rename fields for precision * feat: wrap cnight array types in new structs * feat: use McBlockHash and TxBlockHash in more places * fix: clippy warnings * docs: add change file * docs: add change file * docs: add change file * build: remove unused dep serde_arrays * chore: update metadata * feat: rename MappingEntry utxo_id -> utxo_tx_hash * feat: update type of utxo_tx_hash * feat: change type of cmst block hash * feat: add check for mapping validator auth token * chore: update sqlx cache * test: fix tests for cnight config validation * chore: update cnight config files * test: use aiken cnight smart contracts * fix: use new mapping validator address * chore: update metadata * test: fix tests after cnight pallet update * test: fix more tests, 2 e2e tests still failing * test: fix mint cnight tx budget * test: remove old typescript local-env tests * build: remove leftover target * build: remove leftover target --------- Co-authored-by: Radosław Sporny <404@rspo.dev> * chore: rebuild chainspecs --------- Co-authored-by: Radosław Sporny <404@rspo.dev> * Update governance contracts (#226) * fix: update node-dev-01 gov contracts * fix: qanet and preview gov contracts * chore: update chain-specs * docs: reset changes (node-0.18.0-rc.5) * fix: npm audit * fix metadata --------- Signed-off-by: yHSJ <josh@securitybot.info> Co-authored-by: Radosław Sporny <404@rspo.dev> Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Co-authored-by: Squirrel <giles.cope@shielded.io> Co-authored-by: justinfrevert <81839854+justinfrevert@users.noreply.github.com> Co-authored-by: Fenton Haslam <50406962+Fentonhaslam@users.noreply.github.com> Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> Co-authored-by: Joshua Marchand (JSHy) <79121297+yHSJ@users.noreply.github.com> Co-authored-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* fix: error when loading chain spec for non-dev cfg_preset (#187) (#194) * fix: error when loading chain spec for non-dev cfg_preset --------- Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Co-authored-by: Squirrel <giles.cope@shielded.io> * chore: PC 1.8 deployment fixes (#201) * chore: node-dev-01 new chain spec with PC 1.8 registrations (#191) * chore: PC 1.8 new registrations (#197) * chore: PC 1.8 new registrations * chore: add governance info * chore: fix chain-spec to match PC 1.8 registration (#200) * Cherry pick: bump to ledger ledger-6.1.0-alpha.5 (#203) (#204) * bump to ledger ledger-6.1.0-alpha.5 (#203) (cherry picked from commit b3fac93) * Change GITHUB_TOKEN to GHP_TOKEN in workflow --------- Co-authored-by: Fenton Haslam <50406962+Fentonhaslam@users.noreply.github.com> * Backport gov (#206) * Fix: Federated Authority configurations (#180) * fix federated authorities for qanet and node-dev-01 * chore: regenerate chain_specs * fix: rebuild preview chainspec --------- Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> * [0.18.0 cherry-pick] Add midnight_ prefix to chain ID to follow Polkadot convention (#216) * Add `midnight_` prefix to chain ID to follow Polkadot convention (#188) * feat: add 'midnight_' prefix to all chain ids Network ID is created as a transformation of the chain id * chore: rebuild chainspecs * docs: add change file * feat: add check on network_id spec conformity * chore: rebuild chainspecs * Backport #142 (#220) * Feat: Federated Authority Observation - querying `db-sync` (#142) * feat: query governance data * test: e2e tests base for governance contracts * feat: adding governance contracts to local-env * aaarrrgggg deploy failing * feat: Governance contracts deployed to local-env * federate-authority-configs updated with expected contracts * feat: new members properly read from the minted nft * chore: clean up * feat: add new calls to set addresses and policy_id + benchmarks * nit * chore: make clippy happy * chore: add change file * feat: replace vec by PolicyId and MainchainAddress * chore: regenerate metadata * chore: make clippy happy * test: add test for contracts info setters * chore: update federated configs with preview real data + test fix * chore: regenerate metadata * chore: rebuild metadata * chore: rebuild chain_specs * [cherry-pick 0.18.0] Deduplicate Mapping types (#166) (#221) * Deduplicate Mapping types (#166) * chore: replace Mapping with MappingEntry Signed-off-by: yHSJ <josh@securitybot.info> * chore: changefile * chore: remove unnecessary conversions * fix: regenerate metadata * chore: update metadata * Add change tag * test: fix test compile errors --------- Signed-off-by: yHSJ <josh@securitybot.info> Co-authored-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com> * chore: rebuild metadata * chore: rebuild chainspecs --------- Signed-off-by: yHSJ <josh@securitybot.info> Co-authored-by: Joshua Marchand (JSHy) <79121297+yHSJ@users.noreply.github.com> Co-authored-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com> * Fix node entrypoint (#217) * fix node entrypoint * test * last try * fix: node entrypoint passing `--` as an arg Found when running with SHOW_CONFIG=1: ``` NAME: args HELP: The arguments passed to the node TYPE: Vec < String > DEFAULT: SOURCES: cli CURRENT_VALUE: "--, " ``` --------- Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * [cherry-pick 0.18.0] Update cNight Observation for new Datum structure (#189) (#225) * Update cNight Observation for new Datum structure (#189) * feat: update to follow new datum structure * test: fix tests * fix: DustPublicKey deserialized correctly (PM-19983); fix test * fix: check for DustPublicKey length; Fix missing dereg event (PM-20229) * refactor: rename types - more precise naming * refactor: rename fields for precision * feat: wrap cnight array types in new structs * feat: use McBlockHash and TxBlockHash in more places * fix: clippy warnings * docs: add change file * docs: add change file * docs: add change file * build: remove unused dep serde_arrays * chore: update metadata * feat: rename MappingEntry utxo_id -> utxo_tx_hash * feat: update type of utxo_tx_hash * feat: change type of cmst block hash * feat: add check for mapping validator auth token * chore: update sqlx cache * test: fix tests for cnight config validation * chore: update cnight config files * test: use aiken cnight smart contracts * fix: use new mapping validator address * chore: update metadata * test: fix tests after cnight pallet update * test: fix more tests, 2 e2e tests still failing * test: fix mint cnight tx budget * test: remove old typescript local-env tests * build: remove leftover target * build: remove leftover target --------- Co-authored-by: Radosław Sporny <404@rspo.dev> * chore: rebuild chainspecs --------- Co-authored-by: Radosław Sporny <404@rspo.dev> * Update governance contracts (#226) * fix: update node-dev-01 gov contracts * fix: qanet and preview gov contracts * chore: update chain-specs * Add `preprod` network (#265) * feat: add preprod network * nit * chore: change file * chore: preprod validators * chore: regenerate genesis * fix: align with preview * chore: update preprod pc-config * Revert "chore: update preprod pc-config" This reverts commit 5a43d4c. * Revert "fix: align with preview" This reverts commit 5c4d7e7. * chore: preprod chain-spec * fix: npm audit * fix * remove cache * :/ * change to trixie * Revert "remove cache" This reverts commit e6fdbe2. * recover no cache * Revert "change to trixie" This reverts commit d529e1d. * Revert ":/" This reverts commit 980d1a8. * logs * fix: update to trixie * Revert "logs" This reverts commit 6709891. * undo no-cache --------- Co-authored-by: Radosław Sporny <404@rspo.dev> * docs: reset changes (node-0.18.0-rc.6) * fix: fix main merge * fix: fix main merge 2 * fix: fix main merge 3 * fix: add mainchain memebers for preprod --------- Signed-off-by: yHSJ <josh@securitybot.info> Co-authored-by: Radosław Sporny <404@rspo.dev> Co-authored-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Co-authored-by: Squirrel <giles.cope@shielded.io> Co-authored-by: justinfrevert <81839854+justinfrevert@users.noreply.github.com> Co-authored-by: Fenton Haslam <50406962+Fentonhaslam@users.noreply.github.com> Co-authored-by: Ignacio Palacios <ignacio.palacios.santos@gmail.com> Co-authored-by: Joshua Marchand (JSHy) <79121297+yHSJ@users.noreply.github.com> Co-authored-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Justin Frevert <justinfrevert@gmail.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

ozgb added 2 commits October 29, 2025 16:27

feat: update to follow new datum structure

0bdcf02

test: fix tests

1a8281a

Merge branch 'main' into ozgb/new-cnight-datum

bf59cf0

ozgb mentioned this pull request Oct 30, 2025

fix: toolkit debug build causing test failures #192

Merged

10 tasks

ozgb added 12 commits October 30, 2025 12:24

fix: DustPublicKey deserialized correctly (PM-19983); fix test

59e5847

fix: check for DustPublicKey length; Fix missing dereg event (PM-20229)

0fa7139

Merge branch 'main' into ozgb/new-cnight-datum

cdffda2

refactor: rename types - more precise naming

3d71177

refactor: rename fields for precision

f7de803

feat: wrap cnight array types in new structs

1082dc9

feat: use McBlockHash and TxBlockHash in more places

1a4c262

fix: clippy warnings

da6645e

docs: add change file

9aef465

docs: add change file

763b68f

docs: add change file

102c7a2

build: remove unused dep serde_arrays

24cd135

ozgb added the breaking-change label Oct 31, 2025

ozgb and others added 12 commits October 31, 2025 15:04

chore: update metadata

1e033d1

Merge branch 'main' into ozgb/new-cnight-datum

e254396

feat: rename MappingEntry utxo_id -> utxo_tx_hash

86bafb3

feat: update type of utxo_tx_hash

bf6cd30

feat: change type of cmst block hash

6923413

feat: add check for mapping validator auth token

6472822

chore: update sqlx cache

c446639

test: fix tests for cnight config validation

48e721e

chore: update cnight config files

3d439b2

test: use aiken cnight smart contracts

d8f36c7

fix: use new mapping validator address

4d1fb06

Merge branch 'main' into ozgb/new-cnight-datum

e69a38b

ozgb and others added 4 commits November 3, 2025 15:30

chore: update metadata

565e647

test: fix tests after cnight pallet update

e0eb22e

test: fix more tests, 2 e2e tests still failing

1603061

test: fix mint cnight tx budget

2d9feb5

ozgb marked this pull request as ready for review November 4, 2025 13:59

ozgb requested a review from a team as a code owner November 4, 2025 13:59

ozgb added 4 commits November 4, 2025 14:34

test: remove old typescript local-env tests

6dbf7d0

build: remove leftover target

f0dcba3

Merge branch 'main' into ozgb/new-cnight-datum

ef69877

build: remove leftover target

3e71a37

ozgb requested a review from gilescope November 5, 2025 08:33

ozgb mentioned this pull request Nov 5, 2025

[cherry-pick 0.18.0] Deduplicate Mapping types (#166) #221

Merged

10 tasks

gilescope reviewed Nov 5, 2025

View reviewed changes

Comment thread changes/changed/fix-missing-dereg-event.md

Merge branch 'main' into ozgb/new-cnight-datum

6e8b765

ozgb requested a review from gilescope November 5, 2025 14:47

gilescope approved these changes Nov 5, 2025

View reviewed changes

ozgb enabled auto-merge (squash) November 5, 2025 15:13

ozgb merged commit 9db2811 into main Nov 5, 2025
24 checks passed

ozgb deleted the ozgb/new-cnight-datum branch November 5, 2025 15:29

ozgb mentioned this pull request Nov 5, 2025

[cherry-pick 0.18.0] Update cNight Observation for new Datum structure (#189) #225

Merged

11 tasks

cosmir17 mentioned this pull request Nov 8, 2025

feat: integrate CardanoRewardAddress changes from latest Node midnightntwrk/midnight-indexer#505

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update cNight Observation for new Datum structure#189

Update cNight Observation for new Datum structure#189
ozgb merged 36 commits into
mainfrom
ozgb/new-cnight-datum

ozgb commented Oct 29, 2025 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 29, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

ozgb commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Overview

🗹 TODO before merging

📌 Submission Checklist

🧪 Testing Evidence

🔱 Fork Strategy

Links

Uh oh!

github-actions Bot commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ozgb commented Oct 29, 2025 •

edited

Loading

github-actions Bot commented Oct 29, 2025 •

edited

Loading