chore(deps): bump midnight-storage-core to 1.2.0-rc.2#1388
Merged
Conversation
Bumped storage-core to 1.2.0-rc.2 and modified the patch list such that all deps are independently pinned to the correct versions Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
cosmir17
approved these changes
Apr 22, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* chore(deps): bump midnight-storage-core to 1.2.0-rc.2 Bumped storage-core to 1.2.0-rc.2 and modified the patch list such that all deps are independently pinned to the correct versions Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * docs: add change file Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> --------- Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* chore(deps): bump midnight-storage-core to 1.2.0-rc.2 Bumped storage-core to 1.2.0-rc.2 and modified the patch list such that all deps are independently pinned to the correct versions Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * docs: add change file Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> --------- Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Bumped storage-core to 1.2.0-rc.2 and modified the patch list such that
all deps are independently pinned to the correct versions.
Avoids issue where all deps need to be pinned to a single git tag: https://github.com/midnightntwrk/midnight-node/pull/1360/changes#diff-2e9d962a08321605940b5a657135052fbcef87b5e360662bb527c96d9a615542
This was achieved by using the crate-ledger-8.1.0-rc.1 tag which pulls in all the other ledger deps via crates.io, allowing git patches.
Follows the example set in the indexer's Cargo.toml: https://github.com/midnightntwrk/midnight-indexer/blob/main/Cargo.toml
Closes #1358
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links