feat: add config option to allow symlinks#1372
Merged
Merged
Conversation
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
gilescope
approved these changes
Apr 21, 2026
gilescope
left a comment
Contributor
There was a problem hiding this comment.
Ok, but I think if someone can set your config file contents then you've already lost.
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
cosmir17
approved these changes
Apr 21, 2026
14 tasks
gilescope
added a commit
that referenced
this pull request
Apr 21, 2026
feat: add config option to allow symlinks (#1372)
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* feat: add UNSAFE_ALLOW_SYMLINKS option for safe-read function Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * docs: add change file Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * chore: add pr link to change file Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * chore: ignore clippy warn Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * test: add another symlink test Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> --------- Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* feat: add UNSAFE_ALLOW_SYMLINKS option for safe-read function Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * docs: add change file Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * chore: add pr link to change file Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * chore: ignore clippy warn Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> * test: add another symlink test Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> --------- Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com> Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The new
unsafe_allow_symlinksconfig option permits the use of symlinks when loading configuration files on node boot. Disabled by default to prevent symlink attacks.🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links