Conversation
Klapeyron
approved these changes
Apr 20, 2026
cosmir17
approved these changes
Apr 20, 2026
cosmir17
left a comment
Contributor
There was a problem hiding this comment.
LGTM once the csl.rs sort fix lands and the "Temporarily enable" commit is cleaned up before merge. Thanks for driving the 1.95 upgrade.
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
action that pulls it Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
amazonlinux:2023-minimal. It doesn't come with docker OOTB. Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
…asks Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* chore: update Rust to 1.95 Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> * Apply review comments, fix some CI errors Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> * fix: discrepancy between Earthly midnight-node-ci image tag and github action that pulls it Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> * fix: add docker to ci image. CI image is currently amazonlinux:2023-minimal. It doesn't come with docker OOTB. Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> * fix: Do not poison environment with COMPACTC_HOME for other Earthly tasks Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> --------- Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* chore: update Rust to 1.95 Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> * Apply review comments, fix some CI errors Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> * fix: discrepancy between Earthly midnight-node-ci image tag and github action that pulls it Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> * fix: add docker to ci image. CI image is currently amazonlinux:2023-minimal. It doesn't come with docker OOTB. Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> * fix: Do not poison environment with COMPACTC_HOME for other Earthly tasks Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> --------- Signed-off-by: Lech Głowiak <lech.glowiak@shielded.io> Signed-off-by: Mike Clay <mike.clay@shielded.io>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Updates Rust toolchain to 1.95
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links