Skip to content

chore: add DCO commit-msg git hook#1328

Merged
ozgb merged 3 commits into
mainfrom
ozgb-dco-githook
Apr 14, 2026
Merged

chore: add DCO commit-msg git hook#1328
ozgb merged 3 commits into
mainfrom
ozgb-dco-githook

Conversation

@ozgb

@ozgb ozgb commented Apr 14, 2026

Copy link
Copy Markdown
Contributor

Overview

Adds a git hook to check for the signed-off message - if missing, reject the commit.

🗹 TODO before merging

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

ozgb added 2 commits April 14, 2026 10:42
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
@ozgb ozgb requested a review from a team as a code owner April 14, 2026 09:47
@gilescope

Copy link
Copy Markdown
Contributor

This will disable any existing git hooks people use though... I wonder if there's a hook nesting mechanism?

@ozgb ozgb enabled auto-merge April 14, 2026 12:35
@ozgb ozgb added this pull request to the merge queue Apr 14, 2026
Merged via the queue into main with commit dbe73f5 Apr 14, 2026
33 checks passed
@ozgb ozgb deleted the ozgb-dco-githook branch April 14, 2026 14:09
m2ux added a commit that referenced this pull request Apr 23, 2026
* ci: add githook to check for DCO

Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>

* docs: add more info to DCO githook

Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>

---------

Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
* ci: add githook to check for DCO

Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>

* docs: add more info to DCO githook

Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>

---------

Signed-off-by: Oscar Bailey <79094698+ozgb@users.noreply.github.com>
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants