perf: add weight check to pre_dispatch to quickly dismiss big transactions during block building#1305
Merged
Merged
Conversation
…tions during block building Signed-off-by: Michał Skowron <michal.skowron@shielded.io>
5ebc205 to
ac446f5
Compare
Signed-off-by: Giles Cope <gilescope@gmail.com>
gilescope
approved these changes
Apr 13, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
…tions during block building (#1305) * perf: add weight check to pre_dispatch to quickly dismiss big transactions during block building Signed-off-by: Michał Skowron <michal.skowron@shielded.io> * nit: use ensure Signed-off-by: Giles Cope <gilescope@gmail.com> --------- Signed-off-by: Michał Skowron <michal.skowron@shielded.io> Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Giles Cope <gilescope@gmail.com> Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
…tions during block building (#1305) * perf: add weight check to pre_dispatch to quickly dismiss big transactions during block building Signed-off-by: Michał Skowron <michal.skowron@shielded.io> * nit: use ensure Signed-off-by: Giles Cope <gilescope@gmail.com> --------- Signed-off-by: Michał Skowron <michal.skowron@shielded.io> Signed-off-by: Giles Cope <gilescope@gmail.com> Co-authored-by: Giles Cope <gilescope@gmail.com> Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Weight check in pre_dispatch allows to save on repeating costly validations for too big transactions.
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
Run on the local node and confirmed that it indeed reject too big transactions earlier
🔱 Fork Strategy
Links