feat: add networkId validation on node boot#1265
Merged
Merged
Conversation
Prevents the node from starting up if the configured network id in the chainspec does not equal the network id in the ledger genesis state.
gilescope
approved these changes
Apr 9, 2026
LGLO
reviewed
Apr 9, 2026
LGLO
reviewed
Apr 9, 2026
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* feat: add extra validation when parsing genesis state on node startup Prevents the node from starting up if the configured network id in the chainspec does not equal the network id in the ledger genesis state. * docs: add change file * docs: add pr link to change file * fix: remove unwraps from get_root() Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux
added a commit
that referenced
this pull request
Apr 23, 2026
* feat: add extra validation when parsing genesis state on node startup Prevents the node from starting up if the configured network id in the chainspec does not equal the network id in the ledger genesis state. * docs: add change file * docs: add pr link to change file * fix: remove unwraps from get_root() Signed-off-by: Mike Clay <mike.clay@shielded.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds validation to ensure the
networkIdset in the chainspec matches thenetworkIdused to generate the genesis state.A mismatch can occur if the ledger genesis state was created using a different network id to the setting in the chainspec.
Fixes: #1266
🗹 TODO before merging
📌 Submission Checklist
🧪 Testing Evidence
Please describe any additional testing aside from CI:
🔱 Fork Strategy
Links