Skip to content

feat: toolkit contract e2e tests#1226

Merged
jacek-kurkowski-shielded merged 8 commits into
mainfrom
feature/toolkit-contract-e2e-tests
Apr 13, 2026
Merged

feat: toolkit contract e2e tests#1226
jacek-kurkowski-shielded merged 8 commits into
mainfrom
feature/toolkit-contract-e2e-tests

Conversation

@jacek-kurkowski-shielded

@jacek-kurkowski-shielded jacek-kurkowski-shielded commented Apr 2, 2026

Copy link
Copy Markdown
Contributor

Overview

🗹 TODO before merging

Added e2e test for running Compact contract lifecycle tests against a live node.

  • Ready

📌 Submission Checklist

  • Changes are backward-compatible (or flagged if breaking)
  • Pull request description explains why the change is needed
  • Self-reviewed the diff
  • I have included a change file, or skipped for this reason:
  • If the changes introduce a new feature, I have bumped the node minor version
  • Update documentation (if relevant)
  • Updated AGENTS.md if build commands, architecture, or workflows changed
  • No new todos introduced

🧪 Testing Evidence

Please describe any additional testing aside from CI:

  • Additional tests are provided (if possible)

🔱 Fork Strategy

  • Node Runtime Update
  • Node Client Update
  • Other:
  • N/A

Links

@jacek-kurkowski-shielded jacek-kurkowski-shielded requested a review from a team as a code owner April 2, 2026 09:26
@jacek-kurkowski-shielded jacek-kurkowski-shielded force-pushed the feature/toolkit-contract-e2e-tests branch from 922ed77 to 875ca1a Compare April 7, 2026 09:45
ozgb
ozgb approved these changes Apr 9, 2026
View reviewed changes

@ozgb ozgb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

Comment thread util/toolkit/tests/common/toolkit_helper.rs
Comment thread util/toolkit/tests/common/toolkit_helper.rs Outdated
Comment thread util/toolkit/tests/common/toolkit_helper.rs Outdated
@jacek-kurkowski-shielded

jacek-kurkowski-shielded commented Apr 10, 2026

Copy link
Copy Markdown
Contributor Author

Blocked until: #1295 is merged.

@jacek-kurkowski-shielded jacek-kurkowski-shielded added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit e43fff2 Apr 13, 2026
32 checks passed
@jacek-kurkowski-shielded jacek-kurkowski-shielded deleted the feature/toolkit-contract-e2e-tests branch April 13, 2026 08:11
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
feat: toolkit contract e2e tests (#1226)
791f4cf 
* feat: toolkit contract e2e tests

* chore: audit fix

* chore: make clippy happy

* chore: apply Oscar's comments

* chore: bump axios version
Signed-off-by: Mike Clay <mike.clay@shielded.io>
m2ux added a commit that referenced this pull request Apr 23, 2026
@m2ux
feat: toolkit contract e2e tests (#1226)
969b05e 
* feat: toolkit contract e2e tests

* chore: audit fix

* chore: make clippy happy

* chore: apply Oscar's comments

* chore: bump axios version
Signed-off-by: Mike Clay <mike.clay@shielded.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ozgb ozgb ozgb approved these changes

@rsporny rsporny Awaiting requested review from rsporny

Assignees

No one assigned

Labels

skip-changes-check-all

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jacek-kurkowski-shielded @ozgb