Skip to content

Invoke url replacement logic for batch requests#184

Merged
rkodev merged 2 commits intomainfrom
fix/batch-url-replacements
Apr 17, 2023
Merged

Invoke url replacement logic for batch requests#184
rkodev merged 2 commits intomainfrom
fix/batch-url-replacements

Conversation

@rkodev
Copy link
Contributor

@rkodev rkodev commented Apr 17, 2023

Overview

Blocked by microsoft/kiota-http-go#79

Adds url replacement logic for batch request. The new logic search the http.Client for any existing UrlReplaceHandler middleware and executes url replacement logic on the url path for batch items

Closes #179

Added unit tests to test url replacement logic

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@rkodev rkodev marked this pull request as ready for review April 17, 2023 14:55
@rkodev rkodev merged commit a207dd6 into main Apr 17, 2023
@rkodev rkodev deleted the fix/batch-url-replacements branch April 17, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Batch requests to URLs based on /me fail with 403 due to bad URL

2 participants