Conversation
rkodev
commented
Apr 17, 2023
rkodev
commented
Apr 17, 2023
rkodev
commented
Apr 17, 2023
baywet
requested changes
Apr 17, 2023
628aa4e to
027bf95
Compare
baywet
requested changes
Apr 17, 2023
baywet
requested changes
Apr 17, 2023
Member
baywet
left a comment
There was a problem hiding this comment.
Thanks for making the changes! Changelog entry and it'll be good to go!
Contributor
Author
|
Added changelog entries for this PR |
|
Kudos, SonarCloud Quality Gate passed! |
baywet
approved these changes
Apr 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR partially address issue 179. Batch requests that rely on url replacement logic do not convert the request url for batch items.
The PR increases visibility of some private objects to allow method reuse in implementing libraries. (Reflection is not an option when attempting to invoke priavte methods on private objects)
customTransportis now public and allows type casting to an interface to be specifically typeCustomTransportcustomTransport.GetMiddleWaresreturns the list of middle ware assigned to the trasnport objectUrlReplaceHandler.ReplacePathTokensis now public to allow invoking the method outside the package.