1.20.0 production release #87
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
MIchaelMainer
commented
Feb 4, 2020
- Fix for modifying the Timeout property of a passed HttpClient
- Add DeltaResponseHandler to discover null changes for delta query
- Null auth provider support, fixes Handle null httpClient in SimpleHttpProvider cstor [blocks Azure Functions for M.G] #70
modified: src/Microsoft.Graph.Core/Extensions/BaseRequestExtensions.cs Added WithResponseHandler<T> modified: src/Microsoft.Graph.Core/Requests/BaseRequest.cs Added property to make the response handler accessible. new file: src/Microsoft.Graph.Core/Requests/DeltaResponseHandler.cs Added DeltaResponseHandler to capture changed property names and add them to a list that is added to a prpoerty named 'changes'. modified: src/Microsoft.Graph.Core/Requests/IBaseRequest.cs Added ResponseHandler property. new file: src/Microsoft.Graph.Core/Requests/IResponseHandler.cs Added a common interface for creating response handlers. modified: src/Microsoft.Graph.Core/Requests/ResponseHandler.cs Now implements the common interface. modified: tests/Microsoft.Graph.DotnetCore.Core.Test/Requests/ResponseHandlerTests.cs
* Prevent setting of Timeout property * Add test to validate the change. * Update csproj to new version after release
* Allow null authProvider * Add test to check for not null httpClient
DeltaResponseHandler adds a delta response payload manifest to CollectionPage.AdditionalData
peombwa
approved these changes
Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.