Skip to content

Prevent setting of timeout property in HttpClient #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
andrueastman merged 3 commits into from
Dec 19, 2019
Merged

Prevent setting of timeout property in HttpClient #68

andrueastman merged 3 commits into from
Dec 19, 2019

Conversation

@andrueastman
Copy link
Contributor

@andrueastman andrueastman commented Dec 6, 2019 •
edited
Loading

Fixes #67

Changes proposed in this pull request

This PR undos the automatic setting of timeout property in the HttpClient that is passed in the constructor as the HttpClient could already have been used before to therefore cause an exception.

Steps to test the fix

var httpClient = new HttpClient();
// make any request with the client
var graphServiceClient = new GraphServiceClient(httpClient); // no exception should throw!

Expected behavour

No expection should be thrown on the last line of the example.

@andrueastman andrueastman self-assigned this Dec 6, 2019
@MIchaelMainer MIchaelMainer added this to the 1.20.0 milestone Dec 6, 2019
@andrueastman andrueastman reopened this Dec 10, 2019
@andrueastman andrueastman merged commit 346cc8d into dev Dec 19, 2019
@andrueastman andrueastman deleted the andrueastman/fix-http-client-setting branch December 19, 2019 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@peombwa peombwa peombwa approved these changes

@MIchaelMainer MIchaelMainer MIchaelMainer approved these changes

@darrelmiller darrelmiller Awaiting requested review from darrelmiller

Assignees

@andrueastman andrueastman

Labels

None yet

Projects

None yet

Milestone

1.20.0

Development

Successfully merging this pull request may close these issues.

Timeout property on passed in HttpClient is modified

4 participants

@andrueastman @peombwa @MIchaelMainer