Skip to content

Bugfix: add dynamic signals for work patterns#190

Merged
martinctc merged 3 commits into
mainfrom
fix/workpatterns-dynamic-signals-issue
Oct 1, 2021
Merged

Bugfix: add dynamic signals for work patterns#190
martinctc merged 3 commits into
mainfrom
fix/workpatterns-dynamic-signals-issue

Conversation

@martinctc

@martinctc martinctc commented Sep 24, 2021

Copy link
Copy Markdown
Member

Summary

This branch fixes a bug identified in #189 where dynamic signals have not been implemented when running workpatterns_report().

Changes

The changes made in this PR are:

  1. Add relevant signal arguments in workpatterns_report().
  2. Added dynamic signal implementation for workpatterns_rank().
  3. Update relevant documentation

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.
  • NEWS.md has been updated.

Notes

This fixes #189.
R CMD checks did not pass in GitHub Actions due to a pandoc issue in generating vignettes. However, all checks have passed locally at the point of merging.

@martinctc martinctc changed the title Bugfix: add dynamic signals for work patterns (#189) Bugfix: add dynamic signals for work patterns Oct 1, 2021
@martinctc martinctc self-assigned this Oct 1, 2021
@martinctc martinctc marked this pull request as ready for review October 1, 2021 12:49
@martinctc martinctc added enhancement New feature or request bug Something isn't working labels Oct 1, 2021
@martinctc martinctc merged commit b90dc91 into main Oct 1, 2021
@martinctc martinctc deleted the fix/workpatterns-dynamic-signals-issue branch October 1, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workpatterns_report() function mislabeling activity of collaboration

1 participant