Fix: patch minor bugs#179
Merged
Merged
Conversation
Fixed an issue where the minimum group size threshold wasn't being applied in `workpatterns_classify()`.
Cleaned up parameters in `wellbeing_report()` to make internal function argument values explicit.
Provide more information on the required metrics to `wellbeing_report()`
Implicit argument defaults to `Organization`
Changes to `create_bar()` and `create_stacked()`
This was
linked to
issues
Aug 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch fixes minor bugs in the issue tracker.
Changes
The changes made in this PR are:
Fixed an issue where the minimum group size threshold was not being applied in one of the outputs for
workpatterns_classify_bw(). (Minimum group size doesnt filter summary table output #178)Made it non-mandatory for
keymetrics_scan()not to have all the metrics specified in the argument. (Bug:collaboration_report()cannot run if a required metric does not exist #177)Added
end_hourargument forwellbeing_report()and made parameters for internal arguments within the RMarkdown template explicit, e.g. signals used inworkpatterns_classify(). (Bug:end_hourargument is missing forwellbeing_report()#180)Fixed an issue with
network_p2p()where theweightparameter did not return expected results. (Weight parameter onnetwork_p2p()does not affect output #181)Added new arguments for
create_bar()andcreate_stacked()(experimental)Checks
roxygen2::roxygenise()has been run prior to merging to ensure that.RdandNAMESPACEfiles are up to date.NEWS.mdhas been updated.Notes
This fixes #177, #178, #180, #181.