Skip to content

Feature: add new signals to em_data#191

Merged
martinctc merged 7 commits into
mainfrom
feat/update-em_data
Oct 8, 2021
Merged

Feature: add new signals to em_data#191
martinctc merged 7 commits into
mainfrom
feat/update-em_data

Conversation

@martinctc

@martinctc martinctc commented Oct 8, 2021

Copy link
Copy Markdown
Member

Summary

This branch adds unscheduled calls and meetings signals to the demo hourly collaboration query at em_data. This is added to allow CI/CD tests to be run for the two new signals on relevant functions such as workpatterns_classify(), workpatterns_rank(), and so on.

Changes

The changes made in this PR are:

  1. Added columns with the prefix Meetings_ and Unscheduled_calls_ for the 24 hour columns.
  2. Updated examples for workpatterns_rank() to enable automatic GitHub Actions checks.
  3. Removed all vignette from the R build to pass R CMD checks.

Checks

  • All R CMD checks pass
  • roxygen2::roxygenise() has been run prior to merging to ensure that .Rd and NAMESPACE files are up to date.
  • NEWS.md has been updated.

Notes

This fixes #189.

@martinctc martinctc self-assigned this Oct 8, 2021
@martinctc martinctc added the enhancement New feature or request label Oct 8, 2021
@martinctc martinctc marked this pull request as ready for review October 8, 2021 12:53
@martinctc martinctc merged commit 82ca16d into main Oct 8, 2021
@martinctc martinctc deleted the feat/update-em_data branch October 8, 2021 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

workpatterns_report() function mislabeling activity of collaboration

1 participant