Change how we determine which framework architectures to install #5517
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yao-msft
approved these changes
Jun 11, 2025
This was referenced Jul 1, 2025
Closed
florelis
added a commit
that referenced
this pull request
Jul 4, 2025
`Repair-WinGetPackageManager` is failing to install winget in some Win10 systems. The issue seems come from #5517 and be caused because in some cases we fail to mark any one architecture as the right one to use for dependencies. This PR is a partial revert of #5517 to add the previous logic as a fallback. May fix #5559 (but I haven't set up an environment to test it...) ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5568)
florelis
added a commit
to florelis/winget-cli
that referenced
this pull request
Jul 4, 2025
`Repair-WinGetPackageManager` is failing to install winget in some Win10 systems. The issue seems come from microsoft#5517 and be caused because in some cases we fail to mark any one architecture as the right one to use for dependencies. This PR is a partial revert of microsoft#5517 to add the previous logic as a fallback. May fix microsoft#5559 (but I haven't set up an environment to test it...) ###### Microsoft Reviewers: [Open in CodeFlow](https://microsoft.github.io/open-pr/?codeflow=https://github.com/microsoft/winget-cli/pull/5568)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5020
Change
This change consolidates the choice of which framework architectures to install to a single function and changes it from the current "whatever
OSArchitecturetells us + x86 and x64 if it was ARM64" to the set of architectures that we see installed across all other frameworks. The goal is to work around the fact that in some instances we are not receiving an honest answer fromOSArchitecture.This does rely on the presence of at least one framework package of the system architecture.
It also adds a "break in case of emergency" environment variable
WINGET_PACKAGE_MANAGER_REPAIR_DEPENDENCY_ARCHITECTURESthat can be used to control the set of architectures in the event of unexpected issues.Validation
Manually verified functionality on my dev machine.
Microsoft Reviewers: Open in CodeFlow