fix: make site base path configurable + remove unused workflow#56
Merged
Conversation
- Make astro.config.mjs read site/base from ASTRO_SITE and ASTRO_BASE env vars with GitHub Pages defaults. Azure SWA can now build with ASTRO_BASE=/ so images resolve correctly at root. - Remove unused squad-heartbeat.yml workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Makes the Astro/Starlight docs site deployable under different base paths (GitHub Pages vs Azure Static Web Apps), and removes an unused GitHub Actions workflow.
Changes:
- Read
siteandbasefromASTRO_SITE/ASTRO_BASEenv vars with GitHub Pages defaults. - Delete
.github/workflows/squad-heartbeat.yml.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| site/astro.config.mjs | Makes the docs site URL/base configurable via environment variables. |
| .github/workflows/squad-heartbeat.yml | Removes an unused scheduled/triage workflow. |
Address review feedback: normalize ASTRO_BASE to prevent double-slash URLs when base is '/'. Also fix Header.astro to strip trailing slash from BASE_URL before concatenating nav link paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
richardpark-msft
approved these changes
Mar 4, 2026
spboyer
added a commit
to spboyer/waza-fk
that referenced
this pull request
Mar 5, 2026
…soft#56) * fix: make site base path configurable + remove unused workflow - Make astro.config.mjs read site/base from ASTRO_SITE and ASTRO_BASE env vars with GitHub Pages defaults. Azure SWA can now build with ASTRO_BASE=/ so images resolve correctly at root. - Remove unused squad-heartbeat.yml workflow. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: normalize base path and prevent // in nav links Address review feedback: normalize ASTRO_BASE to prevent double-slash URLs when base is '/'. Also fix Header.astro to strip trailing slash from BASE_URL before concatenating nav link paths. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chlowell
pushed a commit
to chlowell/waza
that referenced
this pull request
Mar 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The docs site at proud-beach Azure SWA has all 13 images broken on the dashboard-explore page.
astro.config.mjshardcodesbase: '/waza'for GitHub Pages, soZoomImage.astroprepends/wazato all image paths. Azure SWA serves at root, so/waza/images/...returns 404.Fix
site/astro.config.mjs: ReadsiteandbasefromASTRO_SITEandASTRO_BASEenv vars, defaulting to GitHub Pages values. Azure SWA builds can setASTRO_BASE=/..github/workflows/squad-heartbeat.yml: No longer used.Verified
/waza/images/explore/...✓ASTRO_BASE=/build (SWA): images →/images/explore/...✓