Skip to content

fix: regression test + changelog for waza suggest deadlock#43

Merged
spboyer merged 2 commits into
mainfrom
copilot/fix-waza-suggest-deadlock
Mar 4, 2026
Merged

fix: regression test + changelog for waza suggest deadlock#43
spboyer merged 2 commits into
mainfrom
copilot/fix-waza-suggest-deadlock

Conversation

Copilot AI commented Mar 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor
  • Review new PR comment and confirm requested action
  • Verify whether merge conflicts can be resolved within this sandbox branch state
  • Re-check CI workflow run status/logs for this branch
  • If feasible, apply minimal conflict resolution and validate tests
  • Reply to PR comment with result and next action
Original prompt

This section details on the original issue you should resolve

<issue_title>waza suggest deadlocks — goroutine panic on copilot SDK stdio transport</issue_title>
<issue_description>## Description

waza suggest deadlocks with a fatal goroutine panic when starting the copilot SDK client via stdio transport. The command is completely unusable.

Repro

waza suggest skills/my-skill --dry-run

Expected

Generates eval suggestions from SKILL.md

Actual

Fatal deadlock:

fatal error: all goroutines are asleep - deadlock!

goroutine 1 [select]:
github.com/github/copilot-sdk/go/internal/jsonrpc2.(*Client).Request(...)
github.com/github/copilot-sdk/go.(*Client).Ping(...)
github.com/github/copilot-sdk/go.(*Client).verifyProtocolVersion(...)
github.com/github/copilot-sdk/go.(*Client).Start(...)

Root Cause

The copilot SDK Start() → verifyProtocolVersion() → Ping() path hangs on the JSON-RPC select, never receiving a response from the copilot CLI server.

Additional Notes

  • Command returns exit code 0 despite the fatal error — should return non-zero
  • waza dev --copilot works fine with the same copilot binary, so the issue is specific to the suggest command path

Environment

  • waza v0.11.0
  • copilot-sdk/go v0.1.22
  • Alpine 3.19 container (Docker)
  • @github/copilot 0.0.417
  • GITHUB_TOKEN set and valid</issue_description>

<agent_instructions>chek with the latest release - revalidate and/or fix issue</agent_instructions>

Comments on the Issue (you are @copilot in this section)

@spboyer Verified fixed in v0.10.0 (commit 33fbece). Copilot Start() now bounded with req.Timeout. @spboyer Re-opening: fix commit (33fbece) is in the repo but the v0.11.0 release binary was NOT rebuilt — it still reports 'waza version 0.9.0' and the deadlock reproduces. The release binary appears to be the old v0.9.0 code.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix deadlock in waza suggest command on copilot SDK fix: regression test + changelog for waza suggest deadlock Mar 3, 2026
@spboyer spboyer marked this pull request as ready for review March 3, 2026 16:22
@spboyer

spboyer commented Mar 3, 2026

Copy link
Copy Markdown
Member

@copilot branch out of date

Copilot AI commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot branch out of date

Branch tip is currently 21d8389. This workspace only has the PR branch ref available (no origin/main), so I can’t safely perform a branch update/rebase here. Please use GitHub’s Update branch (or merge/rebase main into this branch), and I can immediately re-run validation afterward.

spboyer added a commit that referenced this pull request Mar 3, 2026
@spboyer
feat: implement trials for statistical confidence (#43) (#84)
7e7afbb
@spboyer

spboyer commented Mar 3, 2026

Copy link
Copy Markdown
Member

@copilot merge conflicts

Copilot AI commented Mar 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot merge conflicts

Confirmed this branch is in a conflict state that blocks checks (recent Go Build and Test/Squad CI runs are action_required with no jobs started). In this workspace I only have the PR branch ref, so I can’t merge/rebase against main directly. Please resolve via GitHub’s Update branch (or merge main into this branch), and I’ll re-run validation immediately.

@spboyer

spboyer commented Mar 4, 2026

Copy link
Copy Markdown
Member

@copilot - This branch has conflicts that must be resolved, fix this PR

Copilot AI commented Mar 4, 2026

Copy link
Copy Markdown
Contributor Author

@copilot - This branch has conflicts that must be resolved, fix this PR

I re-checked PR #43: it is still mergeable_state: dirty and this branch only has copilot/fix-waza-suggest-deadlock available locally (no origin/main ref in this sandbox), so I can’t perform the required merge/rebase conflict resolution here. Current tip is 21d8389. Please run GitHub Update branch (or merge main into this branch), then I can immediately validate and fix any post-merge issues.

@spboyer spboyer force-pushed the copilot/fix-waza-suggest-deadlock branch from 21d8389 to 33a6d6d Compare March 4, 2026 16:13
Copilot AI and others added 2 commits March 4, 2026 14:33
@spboyer
fix: add regression test and CHANGELOG for waza suggest deadlock fix
9a46960 
Co-authored-by: spboyer <7681382+spboyer@users.noreply.github.com>
@spboyer
fix: correct misspelling cancelled→canceled for lint
c46ad46 
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@spboyer spboyer force-pushed the copilot/fix-waza-suggest-deadlock branch from 8ce44cb to c46ad46 Compare March 4, 2026 19:33
@spboyer spboyer merged commit fd72379 into main Mar 4, 2026
5 checks passed
@spboyer spboyer deleted the copilot/fix-waza-suggest-deadlock branch March 4, 2026 22:20
@spboyer spboyer mentioned this pull request Mar 4, 2026
Merged
spboyer added a commit to spboyer/waza-fk that referenced this pull request Mar 5, 2026
@spboyer
fix: regression test + changelog for waza suggest deadlock (microsoft#43
23c5050 
)

* fix: add regression test and CHANGELOG for waza suggest deadlock fix

Co-authored-by: spboyer <7681382+spboyer@users.noreply.github.com>

* fix: correct misspelling cancelled→canceled for lint

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: spboyer <7681382+spboyer@users.noreply.github.com>
Co-authored-by: Shayne Boyer <spboyer@live.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@spboyer spboyer mentioned this pull request Mar 12, 2026
Merged
4 tasks
@spboyer spboyer mentioned this pull request Feb 28, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chlowell chlowell chlowell approved these changes
@spboyer spboyer Awaiting requested review from spboyer spboyer is a code owner
@richardpark-msft richardpark-msft Awaiting requested review from richardpark-msft

Assignees

@spboyer spboyer

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

waza suggest deadlocks — goroutine panic on copilot SDK stdio transport

3 participants

@spboyer @chlowell