Skip to content

fix: broken images on gh-pages due to missing base path configuration#40

Merged
spboyer merged 2 commits into
mainfrom
copilot/fix-broken-images-dashboard
Mar 3, 2026
Merged

fix: broken images on gh-pages due to missing base path configuration#40
spboyer merged 2 commits into
mainfrom
copilot/fix-broken-images-dashboard

Conversation

Copilot AI commented Mar 2, 2026

Copy link
Copy Markdown
Contributor

The docs site was deploying to Azure Static Web Apps (root /) while image paths in dashboard-explore.mdx were hardcoded with /waza/ prefix — correct for GitHub Pages (microsoft.github.io/waza/) but 404 on SWA. Nav links in the custom Header.astro were also hardcoded without base awareness.

Changes

  • site/astro.config.mjs — add site and base: '/waza' so Astro generates correct asset and navigation paths for GitHub Pages
  • .github/workflows/pages.yml — replace Azure Static Web Apps deployment with proper GitHub Pages workflow (upload-pages-artifact + deploy-pages); add pages: write / id-token: write permissions
  • site/src/components/Header.astro — replace hardcoded absolute nav hrefs with import.meta.env.BASE_URL-prefixed paths so they remain correct regardless of base
// Before
{ label: 'Getting Started', href: '/getting-started/' },

// After
{ label: 'Getting Started', href: `${import.meta.env.BASE_URL}/getting-started/` },

Built output confirms all nav links resolve to /waza/… and all image src attributes match the files served by GitHub Pages at https://microsoft.github.io/waza/images/explore/….

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • telemetry.astro.build
    • Triggering command: /home/REDACTED/work/_temp/ghcca-node/node/bin/node node /home/REDACTED/work/waza/waza/site/node_modules/.bin/astro build (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>Images broken in dashboard page on gh-pages</issue_title>
<issue_description></issue_description>

Comments on the Issue (you are @copilot in this section)


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

…oard images

Co-authored-by: spboyer <7681382+spboyer@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix broken images in dashboard page on gh-pages fix: broken images on gh-pages due to missing base path configuration Mar 2, 2026
@spboyer spboyer marked this pull request as ready for review March 3, 2026 15:33
@spboyer spboyer merged commit 53aab45 into main Mar 3, 2026
5 checks passed
spboyer added a commit that referenced this pull request Mar 3, 2026
spboyer added a commit that referenced this pull request Mar 3, 2026
* feat: implement task completion metrics (#40)

* fix: address copilot review feedback (#40)
spboyer added a commit that referenced this pull request Mar 3, 2026
…#40)

* Initial plan

* fix: add GitHub Pages base path and fix deployment workflow for dashboard images

Co-authored-by: spboyer <7681382+spboyer@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: spboyer <7681382+spboyer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Images broken in dashboard page on gh-pages

2 participants