Skip to content

Determine architecture of remote process on windows#15396

Merged
nohwnd merged 1 commit intomicrosoft:mainfrom
nohwnd:fix-hang-dump-across-architectures-on-windows
Feb 10, 2026
Merged

Determine architecture of remote process on windows#15396
nohwnd merged 1 commit intomicrosoft:mainfrom
nohwnd:fix-hang-dump-across-architectures-on-windows

Conversation

@nohwnd
Copy link
Copy Markdown
Member

@nohwnd nohwnd commented Feb 10, 2026

Description

Figuring out the process architecture of remote process was not implemented for netcore, which makes it not work in dotnet test.
This fixes it for windows, because that is the only place where we use windows api to dump the processes, on macos and linux we use the netcore client.

Related issue

Kindly link any related issues. E.g. Fixes #xyz.

  • I have ensured that there is a previously discussed and approved issue.

@nohwnd nohwnd merged commit a836f4a into microsoft:main Feb 10, 2026
7 checks passed
nohwnd added a commit to nohwnd/vstest that referenced this pull request Apr 13, 2026
…icrosoft#15396

PR microsoft#15266 (Set dotnet_root_<arch> always):
- Test that DOTNET_ROOT_<ARCH> is set early even on non-Windows
- Test that the feature flag VSTEST_DISABLE_DOTNET_ROOT_ON_NONWINDOWS
  suppresses the early set
- Test that an existing DOTNET_ROOT_<ARCH> in the environment is never
  overridden (user's explicit value takes priority)
- Test that omitting VSTEST_DOTNET_ROOT_ARCHITECTURE while providing
  VSTEST_DOTNET_ROOT_PATH throws a descriptive InvalidOperationException

PR microsoft#15184 (Handle dotnet_root in testhost version-aware way):
- Test legacy DOTNET_ROOT forwarding for old x64 testhost (dll absent)
- Test legacy DOTNET_ROOT(x86) forwarding for old x86 testhost (dll absent)
- Test that architecture mismatch prevents any DOTNET_ROOT being set

PR microsoft#15396 (Determine architecture of remote process on Windows):
- Test GetCurrentProcessArchitecture returns a recognised PlatformArchitecture
- Test GetCurrentProcessArchitecture is consistent across calls (caching)
- Test GetProcessArchitecture throws NotImplementedException on non-Windows

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant