Fix regression with workdir symlinks#1053
Merged
benibenj merged 2 commits intomicrosoft:mainfrom Oct 9, 2024
Merged
Conversation
If a workdir was refering a symlink directory, we would pass it to yazl, which would error out because it's a directory. glob recommends using `follow: true` to consider directory symlinks as directories in the collection.
|
i also failed to upgrade to 3.1, and i'm using a local package: "dependencies": {
"typescript-esmsh-plugin": "./typescript-esmsh-plugin"
} |
Contributor
Author
|
Hello @ije, by using this PR you should be able to fix your issue. Download https://github.com/deribaucourt/vscode-vsce/tree/main then build and package vsce and install that version in your workspace. |
Contributor
|
Thanks for looking into this. I feel we need to be a bit careful with this which is why I would propose to have this behind a cli argument. Maybe |
This new behavior fixes packaging with symlinks to directories in extensions. We make it optional in case someone wants to keep the intermediate behavior.
Contributor
Author
|
Thanks for your review @benibenj |
benibenj
approved these changes
Oct 9, 2024
roblourens
approved these changes
Oct 9, 2024
deribaucourt
added a commit
to yoctoproject/vscode-bitbake
that referenced
this pull request
Jan 2, 2025
Following the vsce update, this argument is now required because we have a `lib` symlink folder. See microsoft/vscode-vsce#1053
deribaucourt
added a commit
to savoirfairelinux/vscode-bitbake
that referenced
this pull request
Jan 2, 2025
Following the vsce update, this argument is now required because we have a `lib` symlink folder. See microsoft/vscode-vsce#1053
deribaucourt
added a commit
to yoctoproject/vscode-bitbake
that referenced
this pull request
Jan 8, 2025
Following the vsce update, this argument is now required because we have a `lib` symlink folder. See microsoft/vscode-vsce#1053
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See my comment in #580 (comment)
While upgrading from vsce 2.3 to 3.1, I had this regression which prevented building my package.
I use the following
package.jsonextract:And this folder is a symlink.
If a workdir was refering a symlink directory, we would pass it to yazl, which would error out because it's a directory.
glob recommends using
follow: trueto consider directory symlinks as directories in the collection.