Skip to content

add the ip argument of jupyter server for k8s container #9977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rchiodo merged 1 commit into from
Feb 7, 2020
Merged

add the ip argument of jupyter server for k8s container #9977

rchiodo merged 1 commit into from
Feb 7, 2020

Conversation

@tom-shan
Copy link

@tom-shan tom-shan commented Feb 7, 2020 •
edited
Loading

For #9976

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@codecov-io
Copy link

codecov-io commented Feb 7, 2020 •
edited
Loading

Codecov Report

Merging #9977 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #9977   +/-   ##
======================================
  Coverage    61.2%   61.2%           
======================================
  Files         564     564           
  Lines       30083   30083           
  Branches     4551    4551           
======================================
  Hits        18411   18411           
  Misses      10642   10642           
  Partials     1030    1030
Impacted Files Coverage Δ
src/client/datascience/jupyter/notebookStarter.ts 67.56% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9274435...730f3f9. Read the comment docs.

@msftclas
Copy link

msftclas commented Feb 7, 2020 •
edited
Loading

CLA assistant check
All CLA requirements met.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 7, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rchiodo
Copy link

rchiodo commented Feb 7, 2020

We could probably port this one to the release branch? @DonJayamanne what do you think?

@rchiodo rchiodo merged commit 0562234 into microsoft:master Feb 7, 2020
IanMatthewHuff pushed a commit to IanMatthewHuff/vscode-python that referenced this pull request Feb 7, 2020
@tom-shan @IanMatthewHuff
add the ip argument of jupyter server for k8s container (microsoft#9977)
cfae94e 
fix https://github.com/microsoft/vscode-python/issues/9976
@IanMatthewHuff IanMatthewHuff mentioned this pull request Feb 7, 2020
Merged
10 tasks
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

@IanMatthewHuff IanMatthewHuff Awaiting requested review from IanMatthewHuff

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tom-shan @codecov-io @msftclas @rchiodo @DonJayamanne