Skip to content

fix kernel and server labels when not connected #9965

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
IanMatthewHuff merged 1 commit into from
Feb 6, 2020
Merged

fix kernel and server labels when not connected #9965

IanMatthewHuff merged 1 commit into from
Feb 6, 2020

Conversation

@IanMatthewHuff
Copy link
Member

@IanMatthewHuff IanMatthewHuff commented Feb 6, 2020

For #9933

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR).
  • Title summarizes what is changing.
  • Has a news entry file (remember to thank yourself!).
  • Appropriate comments and documentation strings in the code.
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated.
  • Test plan is updated as appropriate.
  • package-lock.json has been regenerated by running npm install (if dependencies have changed).
  • The wiki is updated with any design decisions/details.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 6, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

IanMatthewHuff
IanMatthewHuff commented Feb 6, 2020
View reviewed changes
src/datascience-ui/interactive-common/kernelSelection.tsx
);
} else {
return (
<div className="kernel-status-section kernel-status-status" style={displayNameTextWidth}>
Copy link
Member Author

@IanMatthewHuff IanMatthewHuff Feb 6, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: Why not show nothing here like we discussed?
A: There is way more funk here with the CSS than I expected. All the flexbox work for making the kernel / server selection shrink correctly kinda assumes that there is something here. Just having "No Kernel" here makes the layout look fine without having to monkey with the CSS flexboxes just before release.

Copy link

@rchiodo rchiodo Feb 6, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@codecov-io
Copy link

codecov-io commented Feb 6, 2020 •
edited
Loading

Codecov Report

Merging #9965 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #9965      +/-   ##
=========================================
+ Coverage   61.18%   61.2%   +0.01%     
=========================================
  Files         564     564              
  Lines       30077   30079       +2     
  Branches     4550    4550              
=========================================
+ Hits        18404   18409       +5     
+ Misses      10642   10640       -2     
+ Partials     1031    1030       -1
Impacted Files Coverage Δ
src/client/common/utils/localize.ts 95.12% <100%> (+0.01%) ⬆️
...datascience/jupyter/liveshare/hostJupyterServer.ts 11% <0%> (-0.12%) ⬇️
src/client/common/process/proc.ts 15.21% <0%> (+0.72%) ⬆️
src/client/datascience/debugLocationTracker.ts 78.12% <0%> (+1.56%) ⬆️
src/client/linters/pydocstyle.ts 88.88% <0%> (+2.22%) ⬆️
src/client/common/utils/platform.ts 76.47% <0%> (+5.88%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad70988...0c6a1f3. Read the comment docs.

@IanMatthewHuff IanMatthewHuff merged commit 4074967 into microsoft:master Feb 6, 2020
IanMatthewHuff added a commit to IanMatthewHuff/vscode-python that referenced this pull request Feb 6, 2020
@IanMatthewHuff
fix kernel and server labels when not connected (microsoft#9965)
99736f2
@IanMatthewHuff IanMatthewHuff deleted the dev/ianhu/fixKernelLabel branch February 6, 2020 23:51
@lock lock bot locked as resolved and limited conversation to collaborators Feb 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne approved these changes

@rchiodo rchiodo rchiodo approved these changes

@DavidKutu DavidKutu Awaiting requested review from DavidKutu

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@IanMatthewHuff @codecov-io @DonJayamanne @rchiodo