Ensure hasInterpreters() API isn't used where necessary, and information returned by it is roughly accurate
#19169
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation returned by it is roughly accurate
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…ation returned by it is roughly accurate (microsoft/vscode-python#19169)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19102
Places where
hasInterpreters()was being used:All these scenarios were considered, for mac interpreter we now do not use
hasInterpreters()and diagnostics were combined. UsinghasInterpreters()without afilteris okay because we trigger a discovery if no Python is installed. For the startup telemetry, usingpython3is now only roughly accurate as refresh is no longer guaranteed to be triggered.We also now don't get conda version if active interpreter is not conda, to avoid running
condabinary, and as it isn't useful to send.