Skip to content

Conversation

@quanzhuo
Copy link

@quanzhuo quanzhuo commented Apr 27, 2022

This PR fix #19036

Now vscode-python depends on vscode-telemetry-extractor@1.9.5 which depends on vscode-ripgrep@1.12.1

When build from source, vscode-ripgrep will download the prebuilt ripgrep binary from github and throw the following error if I am behind a proxy server

Downloading ripgrep failed: TypeError [ERR_INVALID_PROTOCOL]: Protocol "https:" not supported. Expected "http:"

the error is fixed at vscode-ripgrep@1.14.2 . please see this issue for details.

And @vscode/telemetry-extractor@1.9.7 update its dependency to @vscode/ripgrep@1.14.2 which fixed this issue

Signed-off-by: Quan Zhuo <quanzhuo@kylinos.cn>
@kimadeline
Copy link

Thank you for your PR @quanzhuo! Please open an issue in the repo to justify the change you are introducing (it can have the same description as this PR), link it to this PR, and add a news entry (check out our guidelines for more info).

Thank you!

Signed-off-by: Quan Zhuo <quanzhuo@kylinos.cn>
@ghost
Copy link

ghost commented Apr 29, 2022

CLA assistant check
All CLA requirements met.

@quanzhuo
Copy link
Author

This PR Fix #19036

@kimadeline kimadeline merged commit 49dfe9e into microsoft:main Apr 29, 2022
wesm pushed a commit to posit-dev/positron that referenced this pull request Mar 28, 2024
microsoft/vscode-python#19021)

* Update vscode-telemetry-extractor to @vscode-telemetry-extractor@1.9.7

Signed-off-by: Quan Zhuo <quanzhuo@kylinos.cn>

* Add news entry

Signed-off-by: Quan Zhuo <quanzhuo@kylinos.cn>

* Update news/2 Fixes/19036.md

Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to download prebuilt ripgrep binary when build from source

3 participants