Add conda run without output (no bypass) #18319
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kartik Raj <karraj@microsoft.com>
…o25/vscode-python into Add-conda-run-without-bypass
karthiknadig
approved these changes
Jan 20, 2022
Member
karthiknadig
left a comment
There was a problem hiding this comment.
Minor suggestions. There was a space between --format= and the format value.
| protected async runLinter(document: TextDocument, cancellation: CancellationToken): Promise<ILintMessage[]> { | ||
| const messages = await this.run( | ||
| ['--format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', document.uri.fsPath], | ||
| ['--format= %(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', document.uri.fsPath], |
Member
There was a problem hiding this comment.
Suggested change
| ['--format= %(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', document.uri.fsPath], | |
| ['--format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', document.uri.fsPath], |
| protected async runLinter(document: TextDocument, cancellation: CancellationToken): Promise<ILintMessage[]> { | ||
| const messages = await this.run( | ||
| ['--format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', document.uri.fsPath], | ||
| ['--format= %(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', document.uri.fsPath], |
Member
There was a problem hiding this comment.
Suggested change
| ['--format= %(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', document.uri.fsPath], | |
| ['--format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', document.uri.fsPath], |
| test('Flake8', async () => { | ||
| const linter = new Flake8(serviceContainer); | ||
| const expectedArgs = ['--format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', fileUri.fsPath]; | ||
| const expectedArgs = ['--format= %(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', fileUri.fsPath]; |
Member
There was a problem hiding this comment.
Suggested change
| const expectedArgs = ['--format= %(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', fileUri.fsPath]; | |
| const expectedArgs = ['--format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', fileUri.fsPath]; |
| test('Pycodestyle', async () => { | ||
| const linter = new Pycodestyle(serviceContainer); | ||
| const expectedArgs = ['--format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', fileUri.fsPath]; | ||
| const expectedArgs = ['--format= %(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', fileUri.fsPath]; |
Member
There was a problem hiding this comment.
Suggested change
| const expectedArgs = ['--format= %(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', fileUri.fsPath]; | |
| const expectedArgs = ['--format=%(row)d,%(col)d,%(code).1s,%(code)s:%(text)s', fileUri.fsPath]; |
Member
|
You can merge this without the space fix. We will discuss this and address it later. |
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
* Add conda run command * Fix code run * Fix linting * Fix tests * Add news * Fix tests in linter * Fix strings * Fix linters * Fix conda run unit test * Fix funtional tests * Fix single workspace tests * update minimum conda versionvalue * Change sorting timeput * Add timeout time in sorting test * Fix test wothout config * Add more time to timeout in sorting tests * Add conda run command * Fix code run * Fix linting * Fix tests * Add news * Fix tests in linter * Fix strings * Fix linters * Fix conda run unit test * Fix funtional tests * Fix single workspace tests * update minimum conda versionvalue * Change sorting timeput * Add timeout time in sorting test * Add more time to timeout in sorting tests * Update news/1 Enhancements/7696.md Co-authored-by: Kartik Raj <karraj@microsoft.com> * Rix pylint test * Fix lint test * Remove unnecessary interpreter check * Fix timeout test errors * Fix unit test pip installer * Fix IModuleInstaller test * Remove bypass Conda * Remove bypass * Add timeout time * Add conda run command * Fix code run * Fix linting * Fix tests * Add news * Fix tests in linter * Fix strings * Fix linters * Fix conda run unit test * Fix funtional tests * Fix single workspace tests * update minimum conda versionvalue * Change sorting timeput * Add timeout time in sorting test * Add more time to timeout in sorting tests * Add conda run command * Fix code run * Fix test wothout config * Add more time to timeout in sorting tests * Update news/1 Enhancements/7696.md Co-authored-by: Kartik Raj <karraj@microsoft.com> * Rix pylint test * Fix lint test * Remove unnecessary interpreter check * Fix timeout test errors * Fix unit test pip installer * Fix IModuleInstaller test * Remove bypass Conda * Remove bypass * Add timeout time * Fix compilation error * Fix compilation error * Fin pylint linter * Fix installer test Co-authored-by: Kartik Raj <karraj@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add conda run support
Closed #17973