Added replaceAll for string prototype & unit tests #17582
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Member
|
@IceJinx33 I am basing this to OSD branch. Since we are preparing |
karthiknadig
approved these changes
Oct 1, 2021
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Oct 4, 2021
* Added replaceAll for string prototype & unit tests * Create 15288.md * Bug Fix: use replaceAll for replacing separators. * Ran prettier on updated files. Co-authored-by: Aliva Das <ad677@cornell.edu>
karthiknadig
added a commit
that referenced
this pull request
Oct 4, 2021
* Add a quick note about limited support on the web * Tweak the description for virtual workspaces support Closes #17600 * Update to vscode-extension-telemetry 0.4.2 (#17608) * Update to vscode-extension-telemetry 0.4.2 * Add news * Update to latest version of Jedi LS (#17591) * Update to latest version of Jedi LS * Add news * Release candidate (#17610) * Update version * Update change logs * Update notice * Update main branch version (#17611) * Reworded message for A/B testing in the output channel as per issue #6352 (#17584) * Reworded message for A/B testing * Reworded message for A/B testing * Create 6352.md * Added replaceAll for string prototype & unit tests (#17582) * Added replaceAll for string prototype & unit tests * Create 15288.md * Bug Fix: use replaceAll for replacing separators. * Ran prettier on updated files. Co-authored-by: Aliva Das <ad677@cornell.edu> * Issue #17019: Reword commands in Run/Debug button in editor title (#17592) * Reword commands in Run/Reword commands in Run/Debug button in editor title button in editor title * fixed verbage * update the wording in news file. * Update news/2 Fixes/17019.md Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * Update python version in brew command (#17593) * Update python version in brew command Previously brew command installed python version 2 (outdated). Now brew command will install python 3. * Create 17590.md * Rewording news file description Co-authored-by: Karthik Nadig <kanadig@microsoft.com> Co-authored-by: Karthik Nadig <kanadig@microsoft.com> * Improve setting description for enabling A/B tests (#17585) * Issue 7793 solved, rewrite discription for experiment enabling * added news entry * Update news/2 Fixes/7793.md * Update news/2 Fixes/7793.md * Update news/2 Fixes/7793.md * moved news entry from 2 Fixes to 1 Enhancement * Issue #17037: Update text for "entire workspace" when selecting or clearing interpreters (#17588) * update entire workspace text * add news item * add news item Co-authored-by: Quynh <qtd88244@gmail.com> Co-authored-by: Brett Cannon <brcan@microsoft.com> Co-authored-by: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Co-authored-by: Vidushi Gupta <55969597+Vidushi-Gupta@users.noreply.github.com> Co-authored-by: Aliva Das <47723421+IceJinx33@users.noreply.github.com> Co-authored-by: Aliva Das <ad677@cornell.edu> Co-authored-by: Anna Arsentieva <62120244+arsentieva@users.noreply.github.com> Co-authored-by: Carolinekung2 <33406296+Carolinekung2@users.noreply.github.com> Co-authored-by: Thi Le <thi.le@unc.edu> Co-authored-by: Quynhd07 <53713319+Quynhd07@users.noreply.github.com> Co-authored-by: Quynh <qtd88244@gmail.com>
karthiknadig
pushed a commit
to karthiknadig/vscode-python
that referenced
this pull request
Oct 13, 2021
* Added replaceAll for string prototype & unit tests * Create 15288.md * Bug Fix: use replaceAll for replacing separators. * Ran prettier on updated files. Co-authored-by: Aliva Das <ad677@cornell.edu>
karthiknadig
pushed a commit
that referenced
this pull request
Oct 13, 2021
* Added replaceAll for string prototype & unit tests * Create 15288.md * Bug Fix: use replaceAll for replacing separators. * Ran prettier on updated files. Co-authored-by: Aliva Das <ad677@cornell.edu>
|
Hey! The polyfill that is being set on the global |
Member
|
@yotamofek Can you file a bug? We should move this to an independent function rather than trying to change string prototype. Since all extensions are loaded in the same host, any extension that tries to do this is eventually going to step on one another. |
wesm
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…python#17582) * Added replaceAll for string prototype & unit tests * Create 15288.md * Bug Fix: use replaceAll for replacing separators. * Ran prettier on updated files. Co-authored-by: Aliva Das <ad677@cornell.edu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub issue - #15288
Closes #15288