Refreshing PR does not refresh rerun status checks#8454
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes issue #8449 where refreshing a PR does not update the status of rerun checks. When checks are re-run on the same commit (e.g., when a PR is closed and reopened), GitHub's API returns all check run instances, causing the extension to display stale failed statuses instead of the current pending statuses.
Changes:
- Added deduplication logic to filter duplicate status checks, preferring pending checks over completed ones
- Fixed React useEffect missing dependency array to properly react to status changes
- Fixed array mutation issue in status sorting by using slice()
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| webviews/components/merge.tsx | Fixed useEffect dependency array and prevented array mutation during sorting |
| src/github/githubRepository.ts | Added deduplication and overall state computation logic for status checks |
bpasero
approved these changes
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8449