Match github.com empty comment behavior (Fixes #587)#588
Merged
rebornix merged 5 commits intomicrosoft:masterfrom Oct 22, 2018
Merged
Match github.com empty comment behavior (Fixes #587)#588rebornix merged 5 commits intomicrosoft:masterfrom
rebornix merged 5 commits intomicrosoft:masterfrom
Conversation
rebornix
reviewed
Oct 22, 2018
Member
|
It looks to me in overall. I pushed a commit to fix tslint errors but left a tiny comment for JSON.parse. Once that's fixed we can have it merged. Thanks for your help! |
rebornix
reviewed
Oct 22, 2018
| // since it will have a more useful stack | ||
| throw e; | ||
| } | ||
| const firstError = errorObject && errorObject.errors && errorObject.errors[0]; |
Member
|
LGTM. Thanks again for your help! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When you submit a comment and only give new lines it gives a misleading error message.
This PR (fixes #587) contains a small change to match the error behavior that GitHub.com uses in this case
I also added some types for the error object. I looked in the octokit typings and didn't see something there. This is my first time contributing to this repo so please let me know if I am missing or need to change anything.
Thanks for the awesome extension.