Use correct permission to show 'assign yourself' in PR view sidebar#4369
Merged
alexr00 merged 2 commits intomicrosoft:mainfrom Dec 27, 2022
Merged
Use correct permission to show 'assign yourself' in PR view sidebar#4369alexr00 merged 2 commits intomicrosoft:mainfrom
alexr00 merged 2 commits intomicrosoft:mainfrom
Conversation
sandy081
approved these changes
Dec 27, 2022
eslamashour1
pushed a commit
to eslamashour1/vscode-pull-request-github
that referenced
this pull request
Dec 31, 2022
…icrosoft#4369) * Use correct permission to show 'assign yourself' in PR view sidebar * Fix indentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, a person that created a PR is able to see the 'assign yourself' link, even if the user doesn't have the permission to assign. As a result, the user sees an error message: "Must have admin rights to Repository."