Conversation
|
@daviddossett would you like to take this one? I think you may have recently changed some of these things. |
Any idea how this regressed? This seems to have changed since I last looked. |
| id="reply" | ||
| value="Comment" | ||
| type="submit" | ||
| className="secondary" |
There was a problem hiding this comment.
@alexr00 Not sure I have the full context here—we're these styled secondary for some reason?
Before/after screenshots would be helpful here and for all other UI changes @Thomas1664
There was a problem hiding this comment.
I don't actually see a primary class in the css files.
There was a problem hiding this comment.
Styling it as secondary appears to have just been to get the alignment correct: #1350
|
@alexr00 @daviddossett I added screenshots for all UI changes |
|
@Thomas1664 David and I will work on reviewing this, but for future PRs it would really help if you could make small, targeted, PRs that only fix one thing at a time. It's difficult to tell which of your changes affect which elements. |
Thomas1664
left a comment
There was a problem hiding this comment.
@alexr00 I reverted some changes that might have affected many things I and added comments on what individual diffs actually fix if there isn't already some annotation provided by the context of the diff.
|
Thank you! |
Fixes:
padding-rightfor PR labels too smallSavebutton for PR comments andCommentbutton at the bottom of PR webview)Before:
^ Different PR, no additional buttons are hidden.
After: